Repository navigation
Make Sure Logs Are Sent To The Right Place - #229
Merged
Merged
Conversation
gwynne
approved these changes
Sep 23, 2026
| closure( | ||
| _FluentPostgresDatabase( | ||
| database: underlying.sql( | ||
| database: underlying.logging(to: self.logger).sql( |
Member
There was a problem hiding this comment.
Would be nice if we could fix the larger issue with the various versions of logging(to:) in FluentKit and SQLKit; thanks to protocol dispatch rules, it tends not to work with some APIs. But I think that will require API breakage to deal with.
Member
Author
There was a problem hiding this comment.
Yeah once everything is swift concurrency we can just rely on Logger.current, which is what we do in Vapor 5, resolves so many of these issues
gwynne
enabled auto-merge (squash)
September 23, 2026 11:54
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 59.79% 59.79%
=======================================
Files 12 12
Lines 582 582
=======================================
Hits 348 348
Misses 234 234
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 2.13.1
Fixes an issue where logs weren't being sent to the right place in closures.
Resolves #228