vsock: add Firecracker-compatible hybrid host surface - #10
Merged
Conversation
Host connection attempts can arrive before libkrun has shared guest memory and before the RX and TX vrings are active. The backend consumed the connection wakeup and then attempted queue processing. The resulting NoMemoryConfigured or queue iteration error escaped handle_event and terminated the vring worker permanently. Defer queue processing across both initialization boundaries while preserving queued requests and pending vsock packets. Memory setup and the first guest queue kick can then replay the connection after the device becomes usable. Add regression coverage for events received before memory setup and before vring activation. Include dynamic source-port diagnostics to correlate host requests with guest responses. Bound the internal OK handshake to five seconds so a stopped backend cannot retain a connection-capacity lease indefinitely.
Document the persistent vhost-user control socket, shared-memory virtqueue dataplane, eventfd notifications, and per-connection stream adapters. Compare vhost-user-vsock with libkrun built-in vsock port-path API, clarify the remaining relay boundaries, and record the expected performance tradeoffs without claiming unmeasured benchmark results.
The public silo/v2 branch now contains the exact revision already pinned by Cargo.toml and Cargo.lock. Remove the temporary local URL rewrite and unpublished-revision instructions while retaining the immutable commit pin for reproducible builds.
vandycknick
force-pushed
the
feat/adr15
branch
from
August 30, 2026 20:16
0acee9d to
f970bd2
Compare
vandycknick
force-pushed
the
feat/adr15
branch
from
September 1, 2026 19:26
89098c9 to
70d707c
Compare
Reset connections when epoll registration cannot be restored, and avoid advancing receive accounting after monitoring has failed. Own the vring completion worker so spawn failures are reported and teardown closes the channel, drains pending completions, and joins the worker. Normalize SPDX expressions and remove stale comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux datapath
silo/v2revision10b6f752ba8ea735c3d9edaa549599dcf3f98d18Compatibility
VmSpec.vsockcontract with explicit public-surface enablement and an optional mux filenameVerification
make testmake clippy(passes with existing unrelated warnings)cargo fmt --checkcargo test -p vhost-vsock(38 passed)cargo test -p vmmon --features mock-backend connect_response(3 passed)cargo fetch --lockedandcargo build --locked -p krun --features krun-bin --bin krunwith an isolated Cargo home and no Git URL rewritemacOS runtime validation was not run in this Linux environment.