feat: add isUsername validator and fix empty string bug in isNumeric - #2883
Open
Rughena wants to merge 2 commits into
Open
feat: add isUsername validator and fix empty string bug in isNumeric#2883Rughena wants to merge 2 commits into
Rughena wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2883 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 115 +1
Lines 2599 2613 +14
Branches 658 662 +4
=========================================
+ Hits 2599 2613 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add isUsername validator and fix empty string bug in isNumeric
Description
This Pull Request introduces a new string validator and resolves an edge case issue in an existing validator.
isUsername): Created a self contained string validator insrc/lib/isUsername.jsand registered it alphabetically insidesrc/index.js. It ensures a username string has a length between 3 and 15 characters and does not contain restricted special characters (@,#,$).isNumeric): Added an explicit guard clause to returnfalseif the input string is empty (str.length === 0), avoiding unintended behavior down the line.Checklist