Skip to content

fix(isISBN): accept empty options when checking both versions #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a3ylf wants to merge 2 commits into
base: master
Choose a base branch
from
+27 −2
Open

fix(isISBN): accept empty options when checking both versions #2882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2150149
fix(isISBN): accept empty options when checking both versions
a3ylf Sep 7, 2026
797b78e
test(isISBN): cover null options compatibility
a3ylf Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/lib/isISBN.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ export default function isISBN(isbn, options) {

// For backwards compatibility:
// isISBN(str [, version]), i.e. `options` could be used as argument for the legacy `version`
const version = String(options?.version || options);
let version = typeof options === 'object' ? options?.version : options;

if (!(options?.version || options)) {
if (!version) {
return isISBN(isbn, { version: 10 }) || isISBN(isbn, { version: 13 });
}

version = String(version);
const sanitizedIsbn = isbn.replace(/[\s-]+/g, '');

let checksum = 0;
Expand Down
24 changes: 24 additions & 0 deletions test/validators/isISBN.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,30 @@ describe('isISBN', () => {
});
});

[
{ description: 'null options', options: null },
{ description: 'empty options', options: {} },
{ description: 'an undefined version', options: { version: undefined } },
{ description: 'a null version', options: { version: null } },
].forEach(({ description, options }) => {
it(`should validate both ISBN versions with ${description}`, () => {
test({
validator: 'isISBN',
args: [options],
valid: [
'340101319X',
'9784873113685',
],
invalid: [
'3423214121',
'9783836221190',
'foo',
'',
],
});
});
});

describe('(legacy syntax)', () => {
it('should validate ISBNs', () => {
test({
Expand Down
Loading