Skip to content

fix(isLatLong): reject extra coordinate components #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jerry-val wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −2
Open

fix(isLatLong): reject extra coordinate components #2880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05ebfe
fix(isLatLong): reject extra coordinate components
Jerry-val Sep 7, 2026
fd05da7
test(isLatLong): cover extra decimal and DMS components
Jerry-val Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/lib/isLatLong.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import assertString from './util/assertString';
import merge from './util/merge';
import includes from './util/includesString';

const lat = /^\(?[+-]?(90(\.0+)?|[1-8]?\d(\.\d+)?)$/;
const long = /^\s?[+-]?(180(\.0+)?|1[0-7]\d(\.\d+)?|\d{1,2}(\.\d+)?)\)?$/;
Expand All @@ -16,8 +15,8 @@ export default function isLatLong(str, options) {
assertString(str);
options = merge(options, defaultLatLongOptions);

if (!includes(str, ',')) return false;
const pair = str.split(',');
if (pair.length !== 2) return false;
if ((pair[0].startsWith('(') && !pair[1].endsWith(')'))
|| (pair[1].endsWith(')') && !pair[0].startsWith('('))) return false;

Expand Down
27 changes: 27 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12856,6 +12856,33 @@ describe('Validators', () => {
});
});

it('should reject extra decimal LatLong components', () => {
test({
validator: 'isLatLong',
invalid: [
'0,0,',
'0,0,0',
'0,0,garbage',
'0, 0, 0, 0',
'(0, 0),',
'(0, 0),garbage',
],
});
});

it('should reject extra DMS LatLong components', () => {
test({
validator: 'isLatLong',
args: [{ checkDMS: true }],
invalid: [
'40° 26′ 46″ N, 79° 58′ 56″ W,',
'40° 26′ 46″ N, 79° 58′ 56″ W,0',
'40° 26′ 46″ N, 79° 58′ 56″ W,garbage',
'40° 26′ 46″ N, 79° 58′ 56″ W,0,0',
],
});
});

it('should validate postal code', () => {
const fixtures = [
{
Expand Down
Loading