Skip to content

Remove syncWaves from applications - #17

Merged
pinikomarov merged 1 commit into
mainfrom
feat/no-syncWave
Jul 27, 2026
Merged

Remove syncWaves from applications#17
pinikomarov merged 1 commit into
mainfrom
feat/no-syncWave

Conversation

@cjeanner

Copy link
Copy Markdown
Collaborator
This change allows ArgoCD to start every applications at the same time.
This change, in addition to the automated sync and the retry policy,
converges toward a better Validated Patterns integration: they mostly
rely on the "eventually converging" for the applications.

Doing so also enables a faster deployment: in CI, getting up to the
Controlplane takes about 15 minutes - it was closer to 20 minutes with
the sync-waves.

Claude Opus 4.6 was used to ensure tests and documentation were
consistent.

cjeanner added a commit to cjeanner/validatedpatterns-docs that referenced this pull request Jul 24, 2026
After testings, it seems we don't need to set sync-waves at the
application level. This allows to be closer to Validated Patterns
"eventually converging" practices.

Depends-On: validatedpatterns-sandbox/rhoso-gitops#17
This change allows ArgoCD to start every applications at the same time.
This change, in addition to the automated sync and the retry policy,
converges toward a better Validated Patterns integration: they mostly
rely on the "eventually converging" for the applications.

Doing so also enables a faster deployment: in CI, getting up to the
Controlplane takes about 15 minutes - it was closer to 20 minutes with
the sync-waves.

Claude Opus 4.6 was used to ensure tests and documentation were
consistent.
@cjeanner
cjeanner marked this pull request as ready for review July 27, 2026 08:13
@cjeanner cjeanner self-assigned this Jul 27, 2026
@cjeanner
cjeanner requested review from aharivel and pinikomarov July 27, 2026 08:13

@pinikomarov pinikomarov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pinikomarov
pinikomarov merged commit 825be5c into main Jul 27, 2026
19 checks passed
@pinikomarov
pinikomarov deleted the feat/no-syncWave branch July 27, 2026 08:55
cjeanner added a commit to cjeanner/validatedpatterns-docs that referenced this pull request Jul 27, 2026
After testings, it seems we don't need to set sync-waves at the
application level. This allows to be closer to Validated Patterns
"eventually converging" practices.

Depends-On: validatedpatterns-sandbox/rhoso-gitops#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants