feat: add RouterState.isNavigationPending() to detect pre-navigation state#24617
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RouterStategainsisNavigationPending(), returning true whilenavigationTargetis still null (before the first navigation completes), so user code can detect the pre-navigation state without an NPE.Why this matters
In #24471, dereferencing
RouterState.navigationTarget()in browserless tests, or in a running app before the first navigation, throws an NPE. @mcollovati noted the Javadoc already documents the null window, making the NPE an application bug, and proposed exactly this helper so the state is easy to detect. ThenavigationTargetcomponent Javadoc now references the safe check, so users discover it where they would otherwise hit the null.Testing
RouterStateTestcovers both states: pending (null target,isNavigationPending()true,currentView()empty) and completed (target set, pending false).Fixes #24471