refactor: use JS this instead of passing the element via $0 in Element.executeJs#24601
Open
Artur- wants to merge 1 commit into
Open
refactor: use JS this instead of passing the element via $0 in Element.executeJs#24601Artur- wants to merge 1 commit into
this instead of passing the element via $0 in Element.executeJs#24601Artur- wants to merge 1 commit into
Conversation
…ent.executeJs Element.executeJs() automatically binds `this` to the receiving element's DOM node, so passing the same element as an extra parameter just to reference it as $0 is redundant. Replaced these self-references with `this` in scrollIntoView, focus/blur, drag-source/drop-target activation, and setDragImage. setTimeout callbacks were switched to arrow functions so `this` survives the deferred invocation.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Element.executeJs() automatically binds
thisto the receiving element's DOM node, so passing the same element as an extra parameter just to reference it as $0 is redundant. Replaced these self-references withthisin scrollIntoView, focus/blur, drag-source/drop-target activation, and setDragImage. setTimeout callbacks were switched to arrow functions sothissurvives the deferred invocation.