feat: allow custom actions and triggers to consume trigger inputs#24590
Open
Artur- wants to merge 1 commit into
Open
feat: allow custom actions and triggers to consume trigger inputs#24590Artur- wants to merge 1 commit into
Artur- wants to merge 1 commit into
Conversation
Action.Input#toJs was protected, so an Action implemented outside the internal trigger package could not render an Input it received as a parameter — it could only use inputs it captured statically. Widen it (and all overrides) to public so inputs work as action parameters from any package. HandlerInput was package-private, forcing custom trigger families to declare anonymous Action.Input subclasses for handler-scoped event properties. Make the class and its constructor public so they can reuse the canonical implementation the built-in EventData holders use.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action.Input#toJs was protected, so an Action implemented outside the internal trigger package could not render an Input it received as a parameter — it could only use inputs it captured statically. Widen it (and all overrides) to public so inputs work as action parameters from any package.
HandlerInput was package-private, forcing custom trigger families to declare anonymous Action.Input subclasses for handler-scoped event properties. Make the class and its constructor public so they can reuse the canonical implementation the built-in EventData holders use.