feat: public read API on ClipboardBinding#24480
Merged
Merged
Conversation
Clipboard.onClick(button).read(onPayload, onError) — and the single-field convenience variants readText / readHtml — make the read side reachable from the same binding entry point as the write side, instead of forcing callers to instantiate the internal ReadFromClipboardAction themselves. ClipboardPayload moves out of trigger.internal into the public clipboard package so it can sit in the read methods' signatures without leaking an internal type, mirroring how ClipboardContent already lives there for the write side. The private bind() helper on ClipboardBinding is generalised to accept any Action so it can route both write and read actions. The read IT view is restructured into headed sections and gains two new buttons (read-text, read-html); the IT picks up matching scenarios that use the existing resolving-clipboard shim.
Artur-
force-pushed
the
feature/clipboard-read
branch
from
9f2f2c5 to
55e142f
Compare
|
github-project-automation
Bot
moved this to 🔎Iteration reviews
in Vaadin Flow | Hilla | Kits ongoing work
mshabarov
approved these changes
Jun 9, 2026
github-project-automation
Bot
moved this from 🔎Iteration reviews
to Done
in Vaadin Flow | Hilla | Kits ongoing work
Collaborator
|
Hi @Artur- and @mshabarov, when i performed cherry-pick to this commit to 25.2, i have encountered the following issue. Can you take a look and pick it manually? |
Member
Author
|
Need to wait for #24470 |
Artur-
added a commit
that referenced
this pull request
Jun 9, 2026
This PR cherry-picks changes from the original PR #24480 to branch 25.2. --- #### Original PR description > Clipboard.onClick(button).read(onPayload, onError) — and the > single-field convenience variants readText / readHtml — make the > read side reachable from the same binding entry point as the write > side, instead of forcing callers to instantiate the internal > ReadFromClipboardAction themselves. > > ClipboardPayload moves out of trigger.internal into the public > clipboard package so it can sit in the read methods' signatures > without leaking an internal type, mirroring how ClipboardContent > already lives there for the write side. The private bind() helper > on ClipboardBinding is generalised to accept any Action so it can > route both write and read actions. > > The read IT view is restructured into headed sections and gains > two new buttons (read-text, read-html); the IT picks up matching > scenarios that use the existing resolving-clipboard shim. > Co-authored-by: Artur Signell <artur@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clipboard.onClick(button).read(onPayload, onError) — and the
single-field convenience variants readText / readHtml — make the
read side reachable from the same binding entry point as the write
side, instead of forcing callers to instantiate the internal
ReadFromClipboardAction themselves.
ClipboardPayload moves out of trigger.internal into the public
clipboard package so it can sit in the read methods' signatures
without leaking an internal type, mirroring how ClipboardContent
already lives there for the write side. The private bind() helper
on ClipboardBinding is generalised to accept any Action so it can
route both write and read actions.
The read IT view is restructured into headed sections and gains
two new buttons (read-text, read-html); the IT picks up matching
scenarios that use the existing resolving-clipboard shim.