Skip to content

Fix start/end time corruption when reading via HTTP client #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gtopper merged 2 commits into from
Sep 11, 2025
Merged

Fix start/end time corruption when reading via HTTP client #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc3909
Fix start/end time corruption when reading via HTTP client
gtopper Sep 11, 2025
b616fa1
Merge branch 'development' into ML-10926
gtopper Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions clients/py/tests/test_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,14 @@ def test_format_go_time():
assert offset == tz.utcoffset(now).total_seconds(), 'bad offset'


# ML-10926
def test_format_go_time_with_leading_zeroes():
dt = datetime.fromisoformat("2025-09-10T12:00:35.001000")
ts = v3f.http.format_go_time(dt)

assert ts == "2025-09-10T12:00:35.001000000+00:00"


def new_test_client(address='', session=None):
return v3f.HTTPClient(
address=address or 'http://example.com',
Expand Down
2 changes: 1 addition & 1 deletion clients/py/v3io_frames/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def format_go_time(dt):
prefix = dt.strftime('%Y-%m-%dT%H:%M:%S')
nsec = dt.microsecond * 1000
tz = dt.strftime('%z') or '+0000'
return '{}.{}{}:{}'.format(prefix, nsec, tz[:3], tz[3:5])
return '{}.{:09d}{}:{}'.format(prefix, nsec, tz[:3], tz[3:5])


def convert_go_times(d, keys):
Expand Down
Loading