grep: use ASCII word boundaries in the C locale#75
Open
ColumbusLabs wants to merge 1 commit into
Open
Conversation
Collaborator
|
Does Codex know why this PR is wrong or would you like me to explain it? The linked issue does hint at it. |
Author
|
You are right: this patch applies ASCII encoding globally, while the approach discussed on #64 is conditional on C-locale behavior. Since locale selection is not implemented here yet, that would regress the existing UTF-8 path. Before I revise it, would you prefer locale-aware encoding selection as the prerequisite, or a narrower |
Collaborator
|
If I remember correctly, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64.
Summary
-wboundaries with ASCII word-character rulesThis makes bytes at or above
0x80non-word characters under the repository's current C-locale behavior, matching GNU grep for both-wand regex\b.Testing
cargo fmt --all -- --checkcargo check --all-targets --workspacecargo clippy --all-targets --workspace -p uu_grep -- -D warningscargo test --all-targets --workspace