ls: measure the rendered directory header for dired offsets - #14656
Open
ChihweiLHBird wants to merge 1 commit into
Open
ChihweiLHBird wants to merge 1 commit into
ChihweiLHBird wants to merge 1 commit into
Conversation
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
marked this pull request as ready for review
September 17, 2026 19:13
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--diredoffsets must delimit the exact bytes written.write_dir_headermeasured directory headers by their raw path length, whileshow_dir_nameprints them quoted according to the quoting style in force, so any quoting that lengthens a header (-Q,--quoting-style=shell-escape, a name with a space) cut its//SUBDIRED//entry short and shifted every later//DIRED//offset.show_dir_namenow returns the rendered byte length and the bookkeeping uses that. Split out of #14590.Example
Before: the header is printed as
'a b'(5 bytes) but counted asa b(3 bytes), so//SUBDIRED// 2 5covers'aand//DIRED// 62 63lands on the0of the size column instead ofx.After:
//SUBDIRED// 2 7covers'a b'and//DIRED// 64 65coversx, the same offsets GNU prints.