Conversation
|
GNU testsuite comparison: |
krosci
force-pushed
the
mode-reject-octal-in-list
branch
from
September 18, 2026 11:43
ea045fe to
c00b5b8
Compare
krosci
force-pushed
the
mode-reject-octal-in-list
branch
from
September 18, 2026 12:51
c00b5b8 to
ce54f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14421.
The mode parser accepted an octal clause anywhere inside a comma-separated list and skipped empty clauses, where GNU only allows a bare octal as the entire mode string and rejects empty clauses. The comma-list loop was duplicated in chmod, so the grammar now lives once in uucore::mode, with chmod routed through it via parse_chmod_with_naive to keep its umask diagnostic; a caret-aware clause_start in ModeError lets a diagnostic point at the rejected clause. Tests cover both tables from the issue for chmod, mkdir, install, mkfifo and mknod.