Skip to content

openbsd.yml: use system LibreSSL to save build time - #14641

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:libressl
Sep 18, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
oech3:libressl

Conversation

@oech3

@oech3 oech3 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Closes #14640

@oech3
oech3 marked this pull request as ready for review September 17, 2026 10:31
@xtqqczze

Copy link
Copy Markdown
Contributor

Should we exclude vendored openssl in Cargo for OpenBSD?

@xtqqczze

This comment was marked as resolved.

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@oech3

oech3 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Vendored openssl prbably needs C-toolchain (#14449). However, I still think testing system libressl only on the CI (to save time) and setting vendored by default it still reasonable until someone submit official uutils-coreutils package to OpenBSD.

(Our CI for MSYS2(Cygwin) tests system openssl only since the is no actual consumer for vendored openssl).

@xtqqczze

Copy link
Copy Markdown
Contributor

We might need a change to .cargo/config.toml:

[target.x86_64-unknown-openbsd]
linker = "x86_64-unknown-openbsd-gcc"

@oech3

oech3 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

I don't want to override user's choice (gcc, clang, etc...).

@xtqqczze

Copy link
Copy Markdown
Contributor

setting vendored by default it still reasonable until someone submit official uutils-coreutils package to OpenBSD.

I think we should fallback to pure Rust implementation for now, to make clippy happy.

@oech3

oech3 commented Sep 17, 2026 via email

Copy link
Copy Markdown
Contributor Author

@xtqqczze

Copy link
Copy Markdown
Contributor

The OpenBSD CI failure was unrelated, I think this change makes sense though.

@cakebaker
cakebaker merged commit 3a3a3f6 into uutils:main Sep 18, 2026
97 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@oech3
oech3 deleted the libressl branch September 18, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openssl fails to build on OpenBSD

3 participants