Conversation
sylvestre
reviewed
Sep 16, 2026
| #[error("{}", translate!("cp-error-not-all-files-copied"))] | ||
| NotAllFilesCopied, | ||
|
|
||
| /// Extended-attribute copying failed, but every failure was already |
Contributor
There was a problem hiding this comment.
i think it can be a one line comment
sylvestre
reviewed
Sep 16, 2026
|
|
||
| // If copying xattrs failed, propagate that error now with context. | ||
| // | ||
| // `copy_xattrs*` already reported each failing attribute on stderr, so |
Contributor
There was a problem hiding this comment.
same, doesn't have to be that long
|
GNU testsuite comparison: |
krosci
force-pushed
the
mv-copy-xattr-continue-on-error
branch
2 times, most recently
from
September 18, 2026 09:01
6f7d5a0 to
c2bc696
Compare
krosci
force-pushed
the
mv-copy-xattr-continue-on-error
branch
from
September 18, 2026 10:52
c2bc696 to
f61ed64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a cross-device move copies a file or directory that carries several xattrs, a single rejected attribute (e.g. one larger than the destination filesystem allows) used to abort the copy loop, silently dropping every remaining xattr, and the move reported success. GNU mv reports the failing attribute on stderr, copies on through the others, and still exits 0.
copy_xattrs*/apply_xattrs*in uucore now report each failing attribute, keep copying the rest, and return the first error.mvno longer aborts the directory path on a reported failure.cpuses a silent marker so the already-reported per-attribute diagnostics are not echoed a second time.Fixes #14598.