fix(pack): skip ecmascript transforms for URL references#3244
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the JS module rule matching logic in crates/pack-core/src/shared/transforms/mod.rs to match any URL reference type by replacing Some(UrlReferenceSubType::Undefined) with None. Additionally, it removes obsolete error snapshot files and introduces a new snapshot test, foreign_js_new_url, to verify the handling of new URL references in external modules. I have no further feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
📊 Performance Benchmark Report (with-antd)Utoopack Performance ReportReport ID: Executive Summary
Build Phase TimelineShows when each build phase is active and how much CPU it consumes.
Workload Distribution by Diagnostic Tier
Top 20 Tasks by Self-TimeSelf-time is the exclusive duration: time spent in the task itself, not in sub-tasks.
Critical Path AnalysisThe longest sequential dependency chains that determine wall-clock time.
Batching CandidatesHigh-volume tasks dominated by a single parent. If the parent can batch them,
Duration Distribution
Action Items
Report generated by Utoopack Performance Analysis Agent |
Summary
new URL(..., import.meta.url)usage fromnode_modulesAlign the bahaviour with next.js turbopack: https://github.com/fireairforce/next.js/blob/canary/crates/next-core/src/next_shared/transforms/mod.rs#L108-L120
Validation
Update the snapshot test case