Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FortiGate KV parsing truncates quoted messages and identity fields, and explicit SSL-VPN login failures carry
remipwhile their rule expectsorigin.ip. Several security rules also read mismatched fields or count unrelated history. This draft corrects the filter and six rules together; the seventh rule is covered without a rule edit.Validation passed with SDK v1.1.31: 72 synthetic raw fixtures covering all seven predicates, five SDK history-query tests against an isolated localhost mock, and the shared contract-runner overlay. Bounded comparisons and modeled replay used 63 private records from three instances. Existing network fields were preserved; the model recovered 40 messages, 13 descriptions and six SSL peer IPs. Predicate results were one admin candidate, six SSL failures and one critical denied IPS event. These are not generated customer alerts or proof that live thresholds were met.
See
filters/audits/fortigate.mdfor evidence, official references and limits. The closed filter executor and arbitrary CEF variants remain staging checks. Recovery adds parsing work, so measure throughput and alert volumes before production. The nanosecond vendor timestamp is retained until a supported conversion is verified; NAT and file-type fields are not given invented standard meanings.Deploy filter/rules together and allow the 15-minute/one-hour histories to warm up. Appliance/VDOM
lastEvent.*grouping depends on the separately reviewed foundation #2590. Review saved-query compatibility with the explicit outcome vocabulary. This remains a draft againstutmstack/UTMStack:v11; no customer configuration or production deployment was changed.