Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Preserve explicit SourceIp over LocalIP, normalize addresses/outcomes and correct alert grouping.
This draft contains CrowdStrike only: 1 filter changes and 8 correlation-rule changes, plus its own review notes and regression manifest. Reviewed 1 filter configurations and all 17 matching shipped rules; unchanged rules remain outside the diff.
Verification
afterEvents, customlog.*fields and alert-side grouping follow the SDK wiki.git diff --checkpasses.Read
filters/audits/crowdstrike.mdfor scope and source-specific qualifications. Fixtures:plugins/alerts/testdata/filter-contracts/crowdstrike.json.Dependencies and validation limits
Shared test runner: #2590. Apply it before relying on
go test ./...inplugins/alertsto execute this JSON manifest.Runtime dependency: #2590 is also required for the changed
lastEvent.*grouping fields to resolve correctly.Tests start with synthetic extraction results and model normalization, using the real SDK CEL/protobuf. Complex raw-log extraction, dynamic plugins and historical OpenSearch alert generation still need staging validation. This is not a measured reduction in customer alert volume. Review custom rules that consume legacy outcome/severity values before any rollout.
Base: utmstack/UTMStack
v11. Leave as draft for team review. No merge, auto-merge, or production deployment. Split from the audit in #2589.