Skip to content

Fix ad-hoc signed build dying during APK extraction #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utkarshdalal merged 1 commit into from
Aug 30, 2026
Merged

Fix ad-hoc signed build dying during APK extraction #1867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions .github/workflows/adhoc-signed-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ jobs:
if: github.actor == 'utkarshdalal'

@cubic-dev-ai cubic-dev-ai Bot Aug 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The three bundletool build-apks + unzip + rm blocks in the Extract APKs step are near-identical except for the bundle/output file names (and unzip -o vs -p). Since this exact pattern has now been changed once (heap, mv, per-bundle cleanup) and is duplicated across two other workflows (app-release-signed.yml, tagged-release.yml), collapse it into a loop over the bundle pairs so future heap/cleanup changes are made in one place rather than three.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/adhoc-signed-build.yml, line 113:

<comment>The three bundletool build-apks + unzip + rm blocks in the Extract APKs step are near-identical except for the bundle/output file names (and unzip -o vs -p). Since this exact pattern has now been changed once (heap, mv, per-bundle cleanup) and is duplicated across two other workflows (app-release-signed.yml, tagged-release.yml), collapse it into a loop over the bundle pairs so future heap/cleanup changes are made in one place rather than three.</comment>

<file context>
@@ -91,18 +96,28 @@ jobs:
+        java -Xmx3g -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-release.aab --output=app-release.apks --mode=universal
         unzip -o app-release.apks universal.apk
-        java -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-modern-release.aab --output=app-modern-release.apks --mode=universal
+        rm app-release.apks app-release.aab
+        java -Xmx3g -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-modern-release.aab --output=app-modern-release.apks --mode=universal
         unzip -p app-modern-release.apks universal.apk > universal-modern.apk
</file context>


steps:
- name: Free disk space
run: |
sudo rm -rf /usr/share/dotnet /opt/ghc /usr/local/.ghcup /opt/hostedtoolcache/CodeQL /usr/local/share/boost /usr/share/swift
df -h /

- uses: actions/checkout@v4
- name: Check out PR head (fork-aware)
if: ${{ inputs.pr != '' }}
Expand Down Expand Up @@ -91,18 +96,28 @@ jobs:

- name: Stage bundles
run: |
cp app/build/outputs/bundle/legacyRelease/app-legacy-release.aab app-release.aab
cp app/build/outputs/bundle/modernRelease/app-modern-release.aab app-modern-release.aab
cp app/build/outputs/bundle/legacyXrRelease/app-legacyXr-release.aab app-legacy-xr-release.aab
mv app/build/outputs/bundle/legacyRelease/app-legacy-release.aab app-release.aab
mv app/build/outputs/bundle/modernRelease/app-modern-release.aab app-modern-release.aab
mv app/build/outputs/bundle/legacyXrRelease/app-legacyXr-release.aab app-legacy-xr-release.aab

- name: Stop Gradle daemons
run: |
./gradlew --stop
df -h /
free -m

- name: Extract APKs from Bundles
run: |
java -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-release.aab --output=app-release.apks --mode=universal
java -Xmx3g -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-release.aab --output=app-release.apks --mode=universal
unzip -o app-release.apks universal.apk
java -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-modern-release.aab --output=app-modern-release.apks --mode=universal
rm app-release.apks app-release.aab
java -Xmx3g -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-modern-release.aab --output=app-modern-release.apks --mode=universal
unzip -p app-modern-release.apks universal.apk > universal-modern.apk
java -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-legacy-xr-release.aab --output=app-legacy-xr-release.apks --mode=universal
rm app-modern-release.apks app-modern-release.aab
java -Xmx3g -jar tools/bundletool-all-1.17.2.jar build-apks --bundle=app-legacy-xr-release.aab --output=app-legacy-xr-release.apks --mode=universal
unzip -p app-legacy-xr-release.apks universal.apk > universal-legacy-xr.apk
rm app-legacy-xr-release.apks app-legacy-xr-release.aab
df -h /

- name: Copy lineage file
run: |
Expand Down
Loading