Skip to content

feat: add spoilers zone in HLTB section - #1866

Open
RomainFoucher wants to merge 1 commit into
utkarshdalal:masterfrom
RomainFoucher:feat-hltb-spoilers
Open

feat: add spoilers zone in HLTB section#1866
RomainFoucher wants to merge 1 commit into
utkarshdalal:masterfrom
RomainFoucher:feat-hltb-spoilers

Conversation

@RomainFoucher

@RomainFoucher RomainFoucher commented Aug 30, 2026

Copy link
Copy Markdown

Description

Avoid showing How Long To Beat spoilers without approval.

Recording

see

Screenshot_20260813-223424

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by CodeRabbit

  • New Features
    • Added a “Show spoilers” button to the HowLongToBeat section.
    • HowLongToBeat statistics remain hidden until revealed, helping prevent unintended game-time spoilers.
    • Added horizontal scrolling for the statistics after they are revealed.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cc50313b-9dae-45a2-9ec6-08f45592d548

📥 Commits

Reviewing files that changed from the base of the PR and between 036c135 and b36a204.

📒 Files selected for processing (2)
  • app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt
  • app/src/main/res/values/strings.xml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The HLTB information bar now hides statistics behind a reveal button. Reveal state resets for each game. The HLTB link row uses a dedicated clickable wrapper, and a new localized button label is added.

Changes

HLTB spoiler reveal

Layer / File(s) Summary
HLTB state and link layout
app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt
HltbInfoBar tracks reveal state by stats.gameId. The HLTB link uses a dedicated clickable and padded Row.
HLTB statistics overlay
app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt, app/src/main/res/values/strings.xml
The statistics row remains transparent and non-scrollable until revealed. A full-size button reveals the statistics and uses the new hltb_show_spoilers string.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b36a2

The HLTB statistics are hidden until the user chooses to reveal them, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: utkarshdalal, nightwalker743

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: adding a spoiler-reveal zone to the HLTB section.
Description check ✅ Passed The description explains the change, includes visual evidence, selects the change type, and completes all checklist items.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant