Claude/gamenative comprehensive review egflnd

[Hfses]

Description

Recording

Type of Change

• Bug fix
• Performance / stability improvement
• Compatibility improvements
• Other (requires prior approval)

Checklist

• If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
• This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
• I have attached a recording of the change.
• I have read and agree to the contribution guidelines in CONTRIBUTING.md.

---

Summary by cubic

Ships a unified Game Hub (source-agnostic library + stores) and LAN rooms with in‑game chat, alongside a bounded session log and broad performance, stability, and security fixes. Also adds a CI workflow that builds and publishes debug APKs.

• New Features

  • Game Hub (app.gamenative.gamehub): universal StoreProvider + StoreManager, adapters for Steam/GOG/Epic/Amazon/custom, unified library and Stores tab with search/sort, favorites, last‑played, and launch; Hilt module + persistent repo.
  • Custom stores: config-driven store form and persistence; manage in the Stores tab.
  • LAN: create/join rooms with UDP discovery, invite links, chat overlay in‑game, and quick‑menu toggle; holds multicast and wakelocks during sessions; new permissions in Manifest.
  • Session logging + diagnostics: rotating on‑device log with share/export; friendly error hints surfaced in‑game.
  • Local telemetry: per‑game FPS session history and one‑line suggestions on launch.
  • UI/graphics: Low Graphics Mode (FSR upscaling), animated video backgrounds (login and library), Controllers hub, Layout menu entry, rotation now follows device.
  • Runtime compatibility: pre‑launch auto‑fix for Wine/Box64 libc/version mismatches; adds The Last of Us Part I fix (Steam 1888930 and sideloaded).
  • CI: new .github/workflows/build-apk.yml builds and publishes debug APKs; release workflow gated to upstream repo.

• Bug Fixes

  • Native/X server safety: guard PutImage payloads, clamp copy regions, use memmove for overlaps, make epoll event buffer thread‑local; drop duplicate submits.
  • Concurrency/visibility: event bus uses concurrent collections; SteamService flags @Volatile; atomic download counters and listener lists; fix duplicate keys and error isolation in StoreManager.
  • Security: strict path‑traversal checks in Amazon SDK/download and GOG/Epic installers; unique temp names for concurrent downloads.
  • Stability: fix infinite parent walk (ANR), progress NaN, leaked jobs/locks, LAN races and socket handling; robust file moves/copies with cleanup.
  • Defaults/perf: smarter DXVK defaults (async cache on, compiler threads cap, VRAM limits), Box64 preset default to INTERMEDIATE, Wine tweaks (fsync, disable winemenubuilder/crash dialog), thermal governor tied to FPS cap, versioned component extraction, present‑mode/env guards.

^{Written for commit 65d477f. Summary will update on new commits.}

Summary by CodeRabbit

• New Features
  • Added Game Hub with unified libraries, store browsing, search, filtering, favorites, sorting, and custom store support.
  • Added LAN rooms, multiplayer support for up to two controllers, and in-game LAN chat.
  • Added animated login/library backgrounds, custom cover management, low-graphics mode, controller management, and “What’s New”.
  • Added Wine/Proton installation from URLs and bulk component downloads.
• Bug Fixes
  • Improved download reliability, file safety, rendering stability, orientation handling, and compatibility checks.
  • Added clearer installation error messages and session diagnostics.
• Documentation
  • Added engineering, review, architecture, and integration documentation.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request adds a unified Game Hub, LAN rooms and chat, runtime diagnostics and telemetry, configuration improvements, download hardening, rendering and controller updates, CI workflows, localized resources, tests, and engineering documentation.

Changes

GameNative feature and reliability changes

Layer / File(s)	Summary
Build, permissions, and concurrency foundations .github/workflows/*, app/build.gradle.kts, app/src/main/AndroidManifest.xml, app/src/main/java/app/gamenative/data/*	Adds debug APK build/release automation, test defaults, LAN/wakelock permissions, Box64 options, sensor orientation handling, session logging startup, and thread-safe download/event state.
Unified Game Hub architecture app/src/main/java/app/gamenative/gamehub/*, app/src/main/java/app/gamenative/ui/model/GameHubViewModel.kt, app/src/main/java/app/gamenative/ui/screen/gamehub/*, app/src/test/java/app/gamenative/gamehub/*	Introduces unified game models, store adapters, persistence, custom stores, provider registration, aggregation, filtering, sorting, navigation, and tests.
LAN rooms, chat, and application UI app/src/main/java/app/gamenative/lan/*, app/src/main/java/app/gamenative/ui/*, app/src/main/java/app/gamenative/utils/CoverArtManager.kt	Adds LAN hosting/joining, discovery, chat overlays, controller dialogs, wallpapers, login video backgrounds, custom covers, and related navigation/settings.
Runtime compatibility, telemetry, and diagnostics app/src/main/java/app/gamenative/utils/{RuntimeCompatibility,SessionLogger,TelemetryCollector,PerformanceGovernor}.kt, app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt	Adds Wine/Box64 compatibility checks, bounded logs, local telemetry, thermal FPS governance, diagnosis reporting, and launch-time integration.
Download, assembly, and protocol hardening app/src/main/java/app/gamenative/service/{amazon,epic,gog}/*, app/src/main/java/app/gamenative/xserver/*, app/src/main/java/app/gamenative/ui/PluviaMain.kt	Adds path containment checks, rename/copy fallbacks, fail-fast chunk assembly, malformed-request recovery, and install failure feedback.
Container, rendering, and controller behavior app/src/main/java/com/winlator/{container,core,renderer,widget,winhandler,xserver}/*, app/src/main/cpp/*	Updates container persistence and CPU selection, graphics configuration, rendering allocation, touch input reuse, multi-player controller routing, native buffer copying, and 16 KB linker alignment.
Resources and regression coverage app/src/main/res/values*/strings.xml, app/src/test/java/*	Adds localized resources and regression tests for Game Hub mappings, store aggregation, thermal caps, presets, containers, and affinity masks.
Engineering documentation docs/*	Adds delivery, review, server architecture, and XoDos analysis documents.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

• utkarshdalal/GameNative#132: Both modify PluviaMain.preLaunchApp install handling.
• utkarshdalal/GameNative#1471: Both modify multi-player controller and evshim plumbing.
• utkarshdalal/GameNative#1649: Both modify GOG/Epic download assembly flows.

Suggested reviewers: utkarshdalal, phobos665, joshuatam

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 37.02% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is too vague and generic to describe the main change in this large review-focused PR.	Replace it with a concise, specific summary of the primary change, such as the new Game Hub and related UI/runtime fixes.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 16

🧹 Nitpick comments (7)

app/src/main/java/app/gamenative/gamehub/GameLibraryRepository.kt (1)

64-77: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Use ConcurrentHashMap.compute() for atomic read-modify-write.

The setFavorite, setLastPlayed, and setConfigurationProfile methods perform a non-atomic read-modify-write: store[gameId] is read, then store[gameId] = ... is written. If two suspend functions execute concurrently on different dispatchers (e.g., setFavorite + setLastPlayed for the same game), one update can overwrite the other — a classic TOCTOU race. The class doc at line 51 claims "Correct and thread-safe," but ConcurrentHashMap only guarantees atomicity of individual get/put calls, not compound operations.

♻️ Proposed fix using atomic compute()

 override suspend fun setFavorite(gameId: String, favorite: Boolean) {
-    store[gameId] = (store[gameId] ?: GameHubMetadata(gameId)).copy(favorite = favorite)
+    store.compute(gameId) { _, existing -> (existing ?: GameHubMetadata(gameId)).copy(favorite = favorite) }
     publish()
 }

 override suspend fun setLastPlayed(gameId: String, epochMillis: Long) {
-    store[gameId] = (store[gameId] ?: GameHubMetadata(gameId)).copy(lastPlayedAt = epochMillis)
+    store.compute(gameId) { _, existing -> (existing ?: GameHubMetadata(gameId)).copy(lastPlayedAt = epochMillis) }
     publish()
 }

 override suspend fun setConfigurationProfile(gameId: String, profileId: String?) {
-    store[gameId] = (store[gameId] ?: GameHubMetadata(gameId)).copy(configurationProfileId = profileId)
+    store.compute(gameId) { _, existing -> (existing ?: GameHubMetadata(gameId)).copy(configurationProfileId = profileId) }
     publish()
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/gamehub/GameLibraryRepository.kt` around
lines 64 - 77, Replace the non-atomic read-modify-write logic in setFavorite,
setLastPlayed, and setConfigurationProfile with
ConcurrentHashMap.compute(gameId) so each update derives from the current value
and writes atomically, preserving concurrent changes to the same game’s metadata
while retaining the existing publish behavior.

app/src/main/java/app/gamenative/ui/screen/gamehub/CustomStoreDialog.kt (1)

112-112: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Mask the auth token input.

The authToken field renders the API key in plain text via the generic Field composable. On a shared device or screen recording, this exposes the credential to shoulder-surfing.

🔒️ Proposed fix: add password masking to the token field

-            Field("Token / API key", authToken) { authToken = it }
+            OutlinedTextField(
+                value = authToken,
+                onValueChange = { authToken = it },
+                label = { Text("Token / API key") },
+                singleLine = true,
+                visualTransformation = PasswordVisualTransformation(),
+                modifier = Modifier.fillMaxWidth(),
+            )

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/ui/screen/gamehub/CustomStoreDialog.kt` at
line 112, Mask the credential in the authToken field by replacing the generic
Field composable with the project’s password/secret input variant, or add
password visual transformation and appropriate keyboard options to Field if
supported. Update the field in CustomStoreDialog so entered API keys are
rendered as bullets while preserving authToken state updates.

app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInterface.kt (1)

212-230: 📐 Maintainability & Code Quality | 🔵 Trivial

Optional: bail out or warn the user if persisting URI permission fails.

Currently a failed takePersistableUriPermission only logs a warning, yet the code still saves the URI and enables the feature — the video may silently stop working after the app restarts (permission not retained). Consider surfacing this to the user instead of only logging it.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInterface.kt`
around lines 212 - 230, Handle failure from takePersistableUriPermission in the
loginBgVideoPicker callback by warning the user and avoiding
persistence/enabling when permission retention fails; only update
loginBgVideoUri, PrefManager values, and show the success Snackbar after
permission succeeds, while retaining Timber logging for diagnostics.

app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt (1)

57-62: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider exposing exeNameFixes for test override.

fixesProvider has a test-only override hook (setFixesProviderForTests), but exeNameFixes is hardcoded with no override mechanism. If custom-game fix matching needs testing, consider adding a similar provider pattern.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt` around lines
57 - 62, Add a test-overridable provider for the hardcoded exeNameFixes map,
mirroring the existing setFixesProviderForTests pattern and fixesProvider usage
in GameFixesRegistry. Update custom-game executable matching to read through
this provider, while preserving the current map as the production default.

app/src/main/java/com/winlator/xenvironment/components/BionicProgramLauncherComponent.java (1)

226-246: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Local envVars shadows the field this.envVars.

Line 242 declares a new local EnvVars envVars, shadowing the class field mutated just above (lines 229-240). The current code is correct because the field writes explicitly use this., but this pattern is fragile — any future edit inside this method that drops the this. prefix will silently write to the wrong object instead of failing to compile.

Consider renaming the local to avoid the collision (e.g. launchEnvVars) for clarity.

♻️ Suggested rename to eliminate the shadowing

-        EnvVars envVars = new EnvVars();
+        EnvVars launchEnvVars = new EnvVars();

         // Use the ControllerManager's dynamic count for the environment variable
-        envVars.put("EVSHIM_MAX_PLAYERS", String.valueOf(enabledPlayerCount));
-        envVars.put("EVSHIM_SHM_ID", 1);
+        launchEnvVars.put("EVSHIM_MAX_PLAYERS", String.valueOf(enabledPlayerCount));
+        launchEnvVars.put("EVSHIM_SHM_ID", 1);

(and rename remaining envVars uses through the rest of the method accordingly)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@app/src/main/java/com/winlator/xenvironment/components/BionicProgramLauncherComponent.java`
around lines 226 - 246, Rename the local EnvVars variable in the launcher method
from envVars to launchEnvVars, updating all subsequent references while
preserving the explicit this.envVars field writes. This removes the field/local
name collision and keeps environment construction behavior unchanged.

app/src/main/java/app/gamenative/ui/screen/settings/ContentsManagerDialog.kt (1)

78-96: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

refreshInstalled() runs blocking syncContents() on the main thread.

refreshInstalled calls mgr.syncContents() synchronously. It's invoked from LaunchedEffect (Line 95, right after the IO sync at Line 94 — a redundant second sync) and from coroutine continuations at Lines 168/241/368/391 that resume on the main dispatcher. That blocks the UI thread on disk I/O and risks an ANR. Consider wrapping the sync/listing in withContext(Dispatchers.IO) and dropping the duplicate call in the LaunchedEffect.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/ui/screen/settings/ContentsManagerDialog.kt`
around lines 78 - 96, Move the blocking sync and profile listing performed by
refreshInstalled into withContext(Dispatchers.IO), preserving the existing
exception handling and updating installedProfiles safely after the background
work; then remove the redundant mgr.syncContents() call from
LaunchedEffect(currentType), leaving it to invoke refreshInstalled once.

app/src/main/java/app/gamenative/ui/screen/gamehub/GameHubScreen.kt (1)

473-479: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

sourceLabel hardcodes "Local" — it won't be translated in the Portuguese locale.

This PR adds Portuguese translations, but sourceLabel returns hardcoded English strings. Brand names (Steam, GOG, Epic, Amazon) are typically not localized, but "Local" is a generic word that should use a string resource for consistency with the rest of the localized UI.

♻️ Make sourceLabel composable and use string resources

-private fun sourceLabel(source: GameSource): String = when (source) {
-    GameSource.STEAM -> "Steam"
-    GameSource.CUSTOM_GAME -> "Local"
-    GameSource.GOG -> "GOG"
-    GameSource.EPIC -> "Epic"
-    GameSource.AMAZON -> "Amazon"
+@Composable
+private fun sourceLabel(source: GameSource): String = when (source) {
+    GameSource.STEAM -> "Steam"
+    GameSource.CUSTOM_GAME -> stringResource(R.string.game_hub_local)
+    GameSource.GOG -> "GOG"
+    GameSource.EPIC -> "Epic"
+    GameSource.AMAZON -> "Amazon"
 }

This requires adding game_hub_local to strings.xml and values-pt-rBR/strings.xml, and updating the two call sites (lines 227, 414) which are already inside @Composable scopes.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/ui/screen/gamehub/GameHubScreen.kt` around
lines 473 - 479, Update sourceLabel to be composable and return the
game_hub_local string resource for GameSource.CUSTOM_GAME while preserving the
existing brand labels. Add game_hub_local to the default and Portuguese strings
resources, then update both sourceLabel call sites to invoke the composable
function within their existing `@Composable` scopes.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build-apk.yml:
- Around line 25-51: Update the cleanup job’s artifact query to process only
artifacts belonging to build-apk.yml runs, using the workflow-specific runs
endpoint or filtering each artifact’s workflow identity before deletion. Make
KEEP_RUNS retrieval fail safely: enable fail-fast behavior and explicitly abort
cleanup when the API call fails or returns an empty list, before iterating over
artifacts. Preserve deletion only for artifacts from non-retained build-apk.yml
runs, leaving artifacts from all other workflows untouched.

In `@app/src/main/java/app/gamenative/gamehub/StoreProvider.kt`:
- Around line 129-148: Change the default values of canInstall, canUpdate, and
canUninstall in StoreCapabilities to false, matching the unsupported default
StoreProvider operations; ensure concrete providers explicitly set these
capabilities to true only when implemented.

In `@app/src/main/java/app/gamenative/MainActivity.kt`:
- Around line 648-649: Update the orientation-selection logic in the relevant
method so ActivityInfo.SCREEN_ORIENTATION_FULL_SENSOR is returned only when
conformTo contains all four physical orientations; change the conformTo.size >=
3 branch to preserve partial mixed sets for the manual handling path.

In `@app/src/main/java/app/gamenative/service/gog/GOGDownloadManager.kt`:
- Around line 1658-1673: Update createDirectoriesAndLinks() to resolve every
manifest-controlled directory and symlink output path through
resolveInsideInstallDir(installDir, relPath) before mkdirs() or
createSymbolicLink(). Skip entries when the helper returns null, and ensure both
the symlink location and any relevant target path cannot escape the install
directory.
- Around line 964-968: Make terminal chunk failure publication thread-safe in
the download assembly flow: replace the plain mutable assemblyFailure variable
with an AtomicReference or CompletableDeferred, and update all worker writes and
the waiting coroutine’s polling/check logic to use it. Preserve only the first
failure, including the fallback exception message, so concurrent Dispatchers.IO
workers cannot overwrite it and the wait loop reliably aborts.

In `@app/src/main/java/app/gamenative/ui/component/dialog/WhatsNewDialog.kt`:
- Around line 41-82: The WhatsNewDialog content is hardcoded in Portuguese and
must be localized. Move the section titles, item strings, and any other
user-facing text from WHATS_NEW_SECTIONS into string resources, keeping default
values in values and Portuguese translations in values-pt-rBR; update
WhatsNewDialog and WhatsNewSection construction to reference resource IDs or
resolved localized strings.

In `@app/src/main/java/app/gamenative/ui/screen/library/LibraryScreen.kt`:
- Around line 739-758: The wallpaper preference values in LibraryScreen are
incorrectly cached by parameterless remember, so updates are not reflected while
the screen remains composed. Remove remember from libBgVideo, libBgImage,
libBgSound, and showLibWallpaper, or replace them with observable preference
state keyed to the relevant values; apply the same fix to the corresponding
wallpaper setup block referenced near the additional occurrence.

In `@app/src/main/java/app/gamenative/ui/screen/login/LoginBackgroundVideo.kt`:
- Around line 46-56: Update the retained PlayerView whenever the ExoPlayer
instance is recreated by assigning its player to the newly created exoPlayer in
the relevant DisposableEffect or AndroidView update logic. Ensure the previous
player is detached before release, and the current player is attached after
creation, covering both the initialization and cleanup paths in
LoginBackgroundVideo.

In
`@app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupEmulation.kt`:
- Around line 104-120: Add a catch block to the bulkScope.launch
try/catch/finally surrounding ManifestBulkInstaller.installAll, preventing
exceptions from reaching the uncaught coroutine handler and crashing the app. In
the catch, log or report the failure and show a user-facing Snackbar error using
the existing bulkContext and SnackbarManager, while retaining the finally block
that resets downloadAllProgress.

In
`@app/src/main/java/app/gamenative/ui/screen/settings/WineProtonManagerDialog.kt`:
- Around line 577-723: Extract the duplicated extraction, profile validation,
GLIBC compatibility check, untrusted-file handling, and install-result/error
mapping from downloadAndInstallFromUrl, importLauncher, and
downloadAndInstallWineProton into one shared suspend helper accepting a Uri and
returning the mapped installation result/message. Update all three callers to
use this helper while preserving their download/import-specific setup and UI
state handling, so changes such as the GLIBC gate are maintained in one place.

In `@app/src/main/java/app/gamenative/utils/CoverArtManager.kt`:
- Around line 36-54: Update setCustomCover to preserve the existing cover until
the replacement is fully encoded: write the JPEG to a temporary file in the game
folder, verify compression succeeds, then delete old files and atomically rename
or move the temporary file to cover.jpg. Ensure all failure paths clean up the
temporary file and leave the previous cover untouched.

In `@app/src/main/java/app/gamenative/utils/IntentLaunchManager.kt`:
- Around line 260-264: Update mergeConfigurations to parse intent overrides into
a presence-aware patch rather than relying on default-valued fields. Apply
suspendPolicy and merge boolean fields such as launchRealSteam only when their
keys were explicitly supplied, preserving base values for omitted keys while
honoring explicit false values. Ensure all other existing base fields remain
unchanged.

In `@app/src/main/java/app/gamenative/utils/SessionLogger.kt`:
- Line 31: Make timestamp formatting in Tree.log() thread-safe: do not call the
shared timeFmt.format(nowDate()) outside synchronized(lock). Either move the
formatting call inside the existing lock or replace timeFmt with a
ThreadLocal<SimpleDateFormat> and use its formatter in Tree.log(), preserving
the current timestamp format and log output.

In `@app/src/main/java/com/winlator/container/ContainerManager.java`:
- Around line 210-225: Make config loading a required step in the container
duplication flow. In the duplication method around dstContainer.loadData, treat
null/blank config content, JSON parsing errors, and loadData failures as
duplication failures: log the error, remove the partially created destination
directory using the existing cleanup path, and return without calling saveData()
or adding dstContainer to containers. Preserve the existing successful path and
align failure handling with mkdirs() and FileUtils.copy failures.

In `@app/src/main/java/com/winlator/core/DXVKHelper.java`:
- Around line 118-127: Update deviceMemoryCapMb so its returned cap never
exceeds physical RAM: remove the 2048 MB floor and retain only the
70%-of-totalMb calculation, while preserving the existing zero-value handling
for unavailable or invalid memory data.

In `@app/src/main/res/values/strings.xml`:
- Around line 103-127: Replace the Portuguese literals in the default strings
resource for destination_game_hub, game_hub_title, game_hub_custom_stores,
game_hub_add_store, game_hub_remove_store, and tab_store with English
translations, and add the current Portuguese values to the corresponding keys in
values-pt-rBR/strings.xml.

---

Nitpick comments:
In `@app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt`:
- Around line 57-62: Add a test-overridable provider for the hardcoded
exeNameFixes map, mirroring the existing setFixesProviderForTests pattern and
fixesProvider usage in GameFixesRegistry. Update custom-game executable matching
to read through this provider, while preserving the current map as the
production default.

In `@app/src/main/java/app/gamenative/gamehub/GameLibraryRepository.kt`:
- Around line 64-77: Replace the non-atomic read-modify-write logic in
setFavorite, setLastPlayed, and setConfigurationProfile with
ConcurrentHashMap.compute(gameId) so each update derives from the current value
and writes atomically, preserving concurrent changes to the same game’s metadata
while retaining the existing publish behavior.

In `@app/src/main/java/app/gamenative/ui/screen/gamehub/CustomStoreDialog.kt`:
- Line 112: Mask the credential in the authToken field by replacing the generic
Field composable with the project’s password/secret input variant, or add
password visual transformation and appropriate keyboard options to Field if
supported. Update the field in CustomStoreDialog so entered API keys are
rendered as bullets while preserving authToken state updates.

In `@app/src/main/java/app/gamenative/ui/screen/gamehub/GameHubScreen.kt`:
- Around line 473-479: Update sourceLabel to be composable and return the
game_hub_local string resource for GameSource.CUSTOM_GAME while preserving the
existing brand labels. Add game_hub_local to the default and Portuguese strings
resources, then update both sourceLabel call sites to invoke the composable
function within their existing `@Composable` scopes.

In
`@app/src/main/java/app/gamenative/ui/screen/settings/ContentsManagerDialog.kt`:
- Around line 78-96: Move the blocking sync and profile listing performed by
refreshInstalled into withContext(Dispatchers.IO), preserving the existing
exception handling and updating installedProfiles safely after the background
work; then remove the redundant mgr.syncContents() call from
LaunchedEffect(currentType), leaving it to invoke refreshInstalled once.

In
`@app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInterface.kt`:
- Around line 212-230: Handle failure from takePersistableUriPermission in the
loginBgVideoPicker callback by warning the user and avoiding
persistence/enabling when permission retention fails; only update
loginBgVideoUri, PrefManager values, and show the success Snackbar after
permission succeeds, while retaining Timber logging for diagnostics.

In
`@app/src/main/java/com/winlator/xenvironment/components/BionicProgramLauncherComponent.java`:
- Around line 226-246: Rename the local EnvVars variable in the launcher method
from envVars to launchEnvVars, updating all subsequent references while
preserving the explicit this.envVars field writes. This removes the field/local
name collision and keeps environment construction behavior unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 57d8f345-4cad-4ae0-b537-b5d0fcf93c33

📥 Commits

Reviewing files that changed from the base of the PR and between b6fd912 and 65d477f.

📒 Files selected for processing (124)

• .github/workflows/app-release-signed.yml
• .github/workflows/build-apk.yml
• .github/workflows/pluvia-pr-check.yml
• app/build.gradle.kts
• app/src/main/AndroidManifest.xml
• app/src/main/assets/box64_env_vars.json
• app/src/main/cpp/asurfacerenderer/drawable.c
• app/src/main/cpp/patchelf/CMakeLists.txt
• app/src/main/cpp/proot/CMakeLists.txt
• app/src/main/cpp/virglrenderer/CMakeLists.txt
• app/src/main/cpp/winlator/xconnector_epoll.c
• app/src/main/java/app/gamenative/MainActivity.kt
• app/src/main/java/app/gamenative/PluviaApp.kt
• app/src/main/java/app/gamenative/PrefManager.kt
• app/src/main/java/app/gamenative/SteamBootstrap.kt
• app/src/main/java/app/gamenative/data/DownloadInfo.kt
• app/src/main/java/app/gamenative/di/GameHubModule.kt
• app/src/main/java/app/gamenative/events/EventDispatcher.kt
• app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt
• app/src/main/java/app/gamenative/gamefixes/STEAM_1888930.kt
• app/src/main/java/app/gamenative/gamehub/DataStoreGameLibraryRepository.kt
• app/src/main/java/app/gamenative/gamehub/DelegatingStoreProvider.kt
• app/src/main/java/app/gamenative/gamehub/GameHubMappers.kt
• app/src/main/java/app/gamenative/gamehub/GameHubRegistrar.kt
• app/src/main/java/app/gamenative/gamehub/GameLibraryRepository.kt
• app/src/main/java/app/gamenative/gamehub/GameModel.kt
• app/src/main/java/app/gamenative/gamehub/GameModelMapper.kt
• app/src/main/java/app/gamenative/gamehub/README.md
• app/src/main/java/app/gamenative/gamehub/StoreManager.kt
• app/src/main/java/app/gamenative/gamehub/StoreProvider.kt
• app/src/main/java/app/gamenative/gamehub/custom/CustomStoreConfig.kt
• app/src/main/java/app/gamenative/gamehub/custom/CustomStoreRepository.kt
• app/src/main/java/app/gamenative/lan/InGameLanChatOverlay.kt
• app/src/main/java/app/gamenative/lan/LanRoomDialog.kt
• app/src/main/java/app/gamenative/lan/LanRoomManager.kt
• app/src/main/java/app/gamenative/service/SteamService.kt
• app/src/main/java/app/gamenative/service/amazon/AmazonDownloadManager.kt
• app/src/main/java/app/gamenative/service/amazon/AmazonSdkManager.kt
• app/src/main/java/app/gamenative/service/epic/EpicDownloadManager.kt
• app/src/main/java/app/gamenative/service/gog/GOGDownloadManager.kt
• app/src/main/java/app/gamenative/ui/PluviaMain.kt
• app/src/main/java/app/gamenative/ui/component/QuickMenu.kt
• app/src/main/java/app/gamenative/ui/component/dialog/ContainerConfigDialog.kt
• app/src/main/java/app/gamenative/ui/component/dialog/ControllersDialog.kt
• app/src/main/java/app/gamenative/ui/component/dialog/GeneralTab.kt
• app/src/main/java/app/gamenative/ui/component/dialog/GraphicsTab.kt
• app/src/main/java/app/gamenative/ui/component/dialog/WhatsNewDialog.kt
• app/src/main/java/app/gamenative/ui/component/dialog/WineTab.kt
• app/src/main/java/app/gamenative/ui/enums/AppOptionMenuType.kt
• app/src/main/java/app/gamenative/ui/enums/HomeDestination.kt
• app/src/main/java/app/gamenative/ui/enums/LibraryTab.kt
• app/src/main/java/app/gamenative/ui/model/GameHubViewModel.kt
• app/src/main/java/app/gamenative/ui/model/LibraryViewModel.kt
• app/src/main/java/app/gamenative/ui/model/MainViewModel.kt
• app/src/main/java/app/gamenative/ui/screen/HomeScreen.kt
• app/src/main/java/app/gamenative/ui/screen/gamehub/CustomStoreDialog.kt
• app/src/main/java/app/gamenative/ui/screen/gamehub/GameHubScreen.kt
• app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt
• app/src/main/java/app/gamenative/ui/screen/library/LibraryScreen.kt
• app/src/main/java/app/gamenative/ui/screen/library/appscreen/BaseAppScreen.kt
• app/src/main/java/app/gamenative/ui/screen/library/appscreen/CustomGameAppScreen.kt
• app/src/main/java/app/gamenative/ui/screen/library/components/GameOptionsPanel.kt
• app/src/main/java/app/gamenative/ui/screen/library/components/LibraryBackground.kt
• app/src/main/java/app/gamenative/ui/screen/library/components/LibraryOptionsPanel.kt
• app/src/main/java/app/gamenative/ui/screen/library/components/SystemMenu.kt
• app/src/main/java/app/gamenative/ui/screen/login/LoginBackgroundVideo.kt
• app/src/main/java/app/gamenative/ui/screen/login/UserLoginScreen.kt
• app/src/main/java/app/gamenative/ui/screen/settings/ContentsManagerDialog.kt
• app/src/main/java/app/gamenative/ui/screen/settings/DriverManagerDialog.kt
• app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupDebug.kt
• app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupEmulation.kt
• app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInterface.kt
• app/src/main/java/app/gamenative/ui/screen/settings/WineProtonManagerDialog.kt
• app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
• app/src/main/java/app/gamenative/utils/AssetUtils.kt
• app/src/main/java/app/gamenative/utils/ContainerUtils.kt
• app/src/main/java/app/gamenative/utils/CoverArtManager.kt
• app/src/main/java/app/gamenative/utils/CustomGameScanner.kt
• app/src/main/java/app/gamenative/utils/CustomGameWatcher.kt
• app/src/main/java/app/gamenative/utils/DiagnosticsAnalyzer.kt
• app/src/main/java/app/gamenative/utils/IntentLaunchManager.kt
• app/src/main/java/app/gamenative/utils/ManifestBulkInstaller.kt
• app/src/main/java/app/gamenative/utils/ManifestComponentHelper.kt
• app/src/main/java/app/gamenative/utils/PerformanceGovernor.kt
• app/src/main/java/app/gamenative/utils/RuntimeCompatibility.kt
• app/src/main/java/app/gamenative/utils/SessionLogger.kt
• app/src/main/java/app/gamenative/utils/SteamGridDB.kt
• app/src/main/java/app/gamenative/utils/TelemetryCollector.kt
• app/src/main/java/com/winlator/box86_64/Box86_64PresetManager.java
• app/src/main/java/com/winlator/box86_64/rc/RCField.java
• app/src/main/java/com/winlator/container/Container.java
• app/src/main/java/com/winlator/container/ContainerData.kt
• app/src/main/java/com/winlator/container/ContainerManager.java
• app/src/main/java/com/winlator/contents/ContentsManager.java
• app/src/main/java/com/winlator/core/DXVKHelper.java
• app/src/main/java/com/winlator/core/DefaultVersion.java
• app/src/main/java/com/winlator/core/FileUtils.java
• app/src/main/java/com/winlator/core/ProcessHelper.java
• app/src/main/java/com/winlator/core/TarCompressorUtils.java
• app/src/main/java/com/winlator/core/WineUtils.java
• app/src/main/java/com/winlator/core/envvars/EnvVarInfo.kt
• app/src/main/java/com/winlator/renderer/ASurfaceRenderer.java
• app/src/main/java/com/winlator/widget/TouchpadView.java
• app/src/main/java/com/winlator/winhandler/WinHandler.java
• app/src/main/java/com/winlator/xconnector/XConnectorEpoll.java
• app/src/main/java/com/winlator/xenvironment/ImageFs.java
• app/src/main/java/com/winlator/xenvironment/components/BionicProgramLauncherComponent.java
• app/src/main/java/com/winlator/xenvironment/components/GuestProgramLauncherComponent.java
• app/src/main/java/com/winlator/xserver/Drawable.java
• app/src/main/java/com/winlator/xserver/XClientRequestHandler.java
• app/src/main/java/com/winlator/xserver/requests/DrawRequests.java
• app/src/main/res/values-pt-rBR/strings.xml
• app/src/main/res/values/strings.xml
• app/src/test/java/app/gamenative/gamehub/GameHubMappersTest.kt
• app/src/test/java/app/gamenative/gamehub/GameModelMapperTest.kt
• app/src/test/java/app/gamenative/gamehub/StoreManagerTest.kt
• app/src/test/java/app/gamenative/utils/PerformanceGovernorTest.kt
• app/src/test/java/com/winlator/box86_64/Box86_64PresetManagerTest.kt
• app/src/test/java/com/winlator/container/ContainerPersistenceTest.kt
• app/src/test/java/com/winlator/core/ProcessHelperAffinityTest.kt
• docs/RELATORIO_ENGENHARIA_2026-07-09.md
• docs/RELATORIO_REVISAO_2026-07.md
• docs/SERVIDOR_GAMENATIVE_ANALISE.md
• docs/XODOS_ANALISE.md

[coderabbitai]

🗄️ Data Integrity & Integration | 🔴 Critical | ⚡ Quick win

Cleanup job deletes artifacts from ALL workflows, not just build-apk.yml

Two issues in the cleanup job:

1. Cross-workflow deletion (critical): Line 39 lists ALL repository artifacts via repos/$GH_REPO/actions/artifacts, but KEEP_RUNS (line 36) only contains run IDs from the build-apk.yml workflow. Artifacts from other workflows (e.g., app-release-signed.yml uploads signed APKs) have different run IDs, so KEEP stays false and they get deleted.

2. Empty KEEP_RUNS on API failure (major): With set -uo pipefail but no -e (line 35), a gh api failure (rate limit, network) leaves KEEP_RUNS empty. The for K in $KEEP_RUNS loop never executes, so every artifact gets KEEP=false and is deleted — wiping the entire repository's artifact storage.

🔧 Proposed fix: filter by workflow and guard against empty keep list

 jobs:
   cleanup:
     runs-on: ubuntu-latest
     permissions:
       actions: write
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       GH_REPO: ${{ github.repository }}
     steps:
       - name: Delete artifacts older than the last 4 runs
         run: |
           set -uo pipefail
+
+          # Get the workflow ID so we only touch build-apk artifacts, not other workflows'.
+          WF_ID=$(gh api "repos/$GH_REPO/actions/workflows/build-apk.yml" -q '.id')
+          if [ -z "$WF_ID" ]; then
+            echo "Could not resolve workflow ID, skipping cleanup"
+            exit 0
+          fi
+
           KEEP_RUNS=$(gh api "repos/$GH_REPO/actions/workflows/build-apk.yml/runs?per_page=4" \
             -q '.workflow_runs[].id' | tr '\n' ' ')
+          if [ -z "$KEEP_RUNS" ]; then
+            echo "Failed to fetch keep runs, skipping cleanup to avoid deleting everything"
+            exit 0
+          fi
           echo "Keeping artifacts of runs: $KEEP_RUNS"
-          gh api --paginate "repos/$GH_REPO/actions/artifacts?per_page=100" \
-            -q '.artifacts[] | "\(.id) \(.workflow_run.id) \(.size_in_bytes)"' |
+          gh api --paginate "repos/$GH_REPO/actions/artifacts?per_page=100" \
+            -q ".artifacts[] | select(.workflow_run.workflow_id == $WF_ID) | \"\(.id) \(.workflow_run.id) \(.size_in_bytes)\"" |
           while read -r ART_ID RUN_ID SIZE; do
             KEEP=false
             for K in $KEEP_RUNS; do
               if [ "$RUN_ID" = "$K" ]; then KEEP=true; break; fi
             done
             if [ "$KEEP" = "false" ]; then
               echo "Deleting artifact $ART_ID (run $RUN_ID, $SIZE bytes)"
               gh api -X DELETE "repos/$GH_REPO/actions/artifacts/$ART_ID" || true
             fi
           done
           echo "Cleanup done."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	cleanup:
	runs-on: ubuntu-latest
	permissions:
	actions: write
	env:
	GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
	GH_REPO: ${{ github.repository }}
	steps:
	- name: Delete artifacts older than the last 4 runs
	run: |
	set -uo pipefail
	KEEP_RUNS=$(gh api "repos/$GH_REPO/actions/workflows/build-apk.yml/runs?per_page=4" \
	-q '.workflow_runs[].id' | tr '\n' ' ')
	echo "Keeping artifacts of runs: $KEEP_RUNS"
	gh api --paginate "repos/$GH_REPO/actions/artifacts?per_page=100" \
	-q '.artifacts[] | "\(.id) \(.workflow_run.id) \(.size_in_bytes)"' |
	while read -r ART_ID RUN_ID SIZE; do
	KEEP=false
	for K in $KEEP_RUNS; do
	if [ "$RUN_ID" = "$K" ]; then KEEP=true; break; fi
	done
	if [ "$KEEP" = "false" ]; then
	echo "Deleting artifact $ART_ID (run $RUN_ID, $SIZE bytes)"
	gh api -X DELETE "repos/$GH_REPO/actions/artifacts/$ART_ID" || true
	fi
	done
	echo "Cleanup done."
	cleanup:
	runs-on: ubuntu-latest
	permissions:
	actions: write
	env:
	GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
	GH_REPO: ${{ github.repository }}
	steps:
	- name: Delete artifacts older than the last 4 runs
	run: |
	set -uo pipefail
	# Get the workflow ID so we only touch build-apk artifacts, not other workflows'.
	WF_ID=$(gh api "repos/$GH_REPO/actions/workflows/build-apk.yml" -q '.id')
	if [ -z "$WF_ID" ]; then
	echo "Could not resolve workflow ID, skipping cleanup"
	exit 0
	fi
	KEEP_RUNS=$(gh api "repos/$GH_REPO/actions/workflows/build-apk.yml/runs?per_page=4" \
	-q '.workflow_runs[].id' | tr '\n' ' ')
	if [ -z "$KEEP_RUNS" ]; then
	echo "Failed to fetch keep runs, skipping cleanup to avoid deleting everything"
	exit 0
	fi
	echo "Keeping artifacts of runs: $KEEP_RUNS"
	gh api --paginate "repos/$GH_REPO/actions/artifacts?per_page=100" \
	-q ".artifacts[] | select(.workflow_run.workflow_id == $WF_ID) | \"\(.id) \(.workflow_run.id) \(.size_in_bytes)\"" |
	while read -r ART_ID RUN_ID SIZE; do
	KEEP=false
	for K in $KEEP_RUNS; do
	if [ "$RUN_ID" = "$K" ]; then KEEP=true; break; fi
	done
	if [ "$KEEP" = "false" ]; then
	echo "Deleting artifact $ART_ID (run $RUN_ID, $SIZE bytes)"
	gh api -X DELETE "repos/$GH_REPO/actions/artifacts/$ART_ID" || true
	fi
	done
	echo "Cleanup done."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/build-apk.yml around lines 25 - 51, Update the cleanup
job’s artifact query to process only artifacts belonging to build-apk.yml runs,
using the workflow-specific runs endpoint or filtering each artifact’s workflow
identity before deletion. Make KEEP_RUNS retrieval fail safely: enable fail-fast
behavior and explicitly abort cleanup when the API call fails or returns an
empty list, before iterating over artifacts. Preserve deletion only for
artifacts from non-retained build-apk.yml runs, leaving artifacts from all other
workflows untouched.

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Do not advertise unsupported operations by default.

StoreCapabilities() claims install/update/uninstall support, while the matching default provider methods are unsupported (or return a misleading UP_TO_DATE). Any provider using default capabilities can expose actions that cannot work. Default optional capabilities to false; concrete providers should opt in explicitly.

Proposed fix

 data class StoreCapabilities(
     val canSearch: Boolean = false,
-    val canInstall: Boolean = true,
-    val canUpdate: Boolean = true,
-    val canUninstall: Boolean = true,
+    val canInstall: Boolean = false,
+    val canUpdate: Boolean = false,
+    val canUninstall: Boolean = false,

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	/** Declares which optional operations a [StoreProvider] actually supports. */
	data class StoreCapabilities(
	val canSearch: Boolean = false,
	val canInstall: Boolean = true,
	val canUpdate: Boolean = true,
	val canUninstall: Boolean = true,
	val canImportExisting: Boolean = false,
	val hasCloudSaves: Boolean = false,
	val requiresAuth: Boolean = true,
	/** Supports interactive login/logout (vs. auth handled elsewhere). */
	val canLogin: Boolean = false,
	/** Exposes a user profile (name/avatar). */
	val hasProfile: Boolean = false,
	/** Supports pause/resume/cancel of downloads. */
	val canControlDownloads: Boolean = false,
	/** Supports verifying installed files. */
	val canVerify: Boolean = false,
	/** Supports repairing installed files. */
	val canRepair: Boolean = false,
	)
	/** Declares which optional operations a [StoreProvider] actually supports. */
	data class StoreCapabilities(
	val canSearch: Boolean = false,
	val canInstall: Boolean = false,
	val canUpdate: Boolean = false,
	val canUninstall: Boolean = false,
	val canImportExisting: Boolean = false,
	val hasCloudSaves: Boolean = false,
	val requiresAuth: Boolean = true,
	/** Supports interactive login/logout (vs. auth handled elsewhere). */
	val canLogin: Boolean = false,
	/** Exposes a user profile (name/avatar). */
	val hasProfile: Boolean = false,
	/** Supports pause/resume/cancel of downloads. */
	val canControlDownloads: Boolean = false,
	/** Supports verifying installed files. */
	val canVerify: Boolean = false,
	/** Supports repairing installed files. */
	val canRepair: Boolean = false,
	)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/gamehub/StoreProvider.kt` around lines 129 -
148, Change the default values of canInstall, canUpdate, and canUninstall in
StoreCapabilities to false, matching the unsupported default StoreProvider
operations; ensure concrete providers explicitly set these capabilities to true
only when implemented.

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Do not widen three-orientation sets to FULL_SENSOR.

A set such as landscape + reverse-landscape + portrait excludes reverse-portrait, but FULL_SENSOR allows it. Only use FULL_SENSOR when all four physical orientations are allowed; leave partial mixed sets on the manual path.

Proposed fix

-            conformTo.size >= 3 -> ActivityInfo.SCREEN_ORIENTATION_FULL_SENSOR
+            conformTo.containsAll(
+                EnumSet.of(
+                    Orientation.LANDSCAPE,
+                    Orientation.REVERSE_LANDSCAPE,
+                    Orientation.PORTRAIT,
+                    Orientation.REVERSE_PORTRAIT,
+                ),
+            ) -> ActivityInfo.SCREEN_ORIENTATION_FULL_SENSOR

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	conformTo.size >= 3 -> ActivityInfo.SCREEN_ORIENTATION_FULL_SENSOR
	else -> null
	conformTo.containsAll(
	EnumSet.of(
	Orientation.LANDSCAPE,
	Orientation.REVERSE_LANDSCAPE,
	Orientation.PORTRAIT,
	Orientation.REVERSE_PORTRAIT,
	),
	) -> ActivityInfo.SCREEN_ORIENTATION_FULL_SENSOR
	else -> null

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/MainActivity.kt` around lines 648 - 649,
Update the orientation-selection logic in the relevant method so
ActivityInfo.SCREEN_ORIENTATION_FULL_SENSOR is returned only when conformTo
contains all four physical orientations; change the conformTo.size >= 3 branch
to preserve partial mixed sets for the manual handling path.

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Publish terminal chunk failures safely across coroutines.

assemblyFailure is a plain mutable variable written by concurrent Dispatchers.IO workers and polled by the waiting coroutine. The poller may never observe the write, reintroducing the download hang this change intends to fix. Use an AtomicReference or CompletableDeferred and preserve the first failure.

Proposed fix

+import java.util.concurrent.atomic.AtomicReference
...
-            var assemblyFailure: Throwable? = null
+            val assemblyFailure = AtomicReference<Throwable?>(null)
...
-                                assemblyFailure = exception ?: Exception("Chunk $chunkMd5 failed permanently")
+                                assemblyFailure.compareAndSet(
+                                    null,
+                                    exception ?: Exception("Chunk $chunkMd5 failed permanently"),
+                                )
...
-                if (assemblyFailure != null) {
+                assemblyFailure.get()?.let { failure ->
                     networkChunkJob.cancel()
                     assembleJob.cancel()
-                    return@withContext Result.failure(assemblyFailure!!)
+                    return@withContext Result.failure(failure)
                 }

Also applies to: 1037-1043

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/service/gog/GOGDownloadManager.kt` around
lines 964 - 968, Make terminal chunk failure publication thread-safe in the
download assembly flow: replace the plain mutable assemblyFailure variable with
an AtomicReference or CompletableDeferred, and update all worker writes and the
waiting coroutine’s polling/check logic to use it. Preserve only the first
failure, including the fallback exception message, so concurrent Dispatchers.IO
workers cannot overwrite it and the wait loop reliably aborts.

[coderabbitai]

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Apply containment validation to manifest directories and symlink locations.

The helper protects assembled files, but createDirectoriesAndLinks() still constructs File(installDir, relPath) directly for manifest-controlled directory and link paths. A ../../ link or directory path can still escape the game directory. Resolve those output paths through this helper before mkdirs() or createSymbolicLink().

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/service/gog/GOGDownloadManager.kt` around
lines 1658 - 1673, Update createDirectoriesAndLinks() to resolve every
manifest-controlled directory and symlink output path through
resolveInsideInstallDir(installDir, relPath) before mkdirs() or
createSymbolicLink(). Skip entries when the helper returns null, and ensure both
the symlink location and any relevant target path cannot escape the install
directory.

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift

Preserve override field presence instead of inferring it from defaults.

A JSON suspendPolicy is parsed but never applied (mergeConfigurations always keeps the base value); explicit false values for fields such as launchRealSteam are likewise indistinguishable from omitted fields. Parse into a presence-aware patch and merge only keys actually supplied by the intent.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/utils/IntentLaunchManager.kt` around lines
260 - 264, Update mergeConfigurations to parse intent overrides into a
presence-aware patch rather than relying on default-valued fields. Apply
suspendPolicy and merge boolean fields such as launchRealSteam only when their
keys were explicitly supplied, preserving base values for omitted keys while
honoring explicit false values. Ensure all other existing base fields remain
unchanged.

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

SimpleDateFormat is not thread-safe; Tree.log() formats timestamps outside the lock.

timeFmt is a shared SimpleDateFormat instance. Tree.log() calls timeFmt.format(nowDate()) at line 109 inside buildString{} but outside synchronized(lock). Timber invokes log() from whatever thread logs the message, so concurrent calls can corrupt SimpleDateFormat's internal CalendarBuilder/DigitList state, causing ArrayIndexOutOfBoundsException, NumberFormatException, or garbled timestamps.

🔒 Minimal fix: synchronize the format call

     override fun log(priority: Int, tag: String?, message: String, t: Throwable?) {
         val line = buildString {
-            append(timeFmt.format(nowDate()))
+            append(synchronized(lock) { timeFmt.format(nowDate()) })
             append(' ')
             append(levelChar(priority))
             append('/')
             append(tag ?: "app")
             append(": ")
             append(message)
         }
         append(line)
         if (t != null) append(android.util.Log.getStackTraceString(t))
     }

Alternatively, replace timeFmt with a ThreadLocal<SimpleDateFormat> to avoid lock contention on the hot path.

Also applies to: 107-119

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/utils/SessionLogger.kt` at line 31, Make
timestamp formatting in Tree.log() thread-safe: do not call the shared
timeFmt.format(nowDate()) outside synchronized(lock). Either move the formatting
call inside the existing lock or replace timeFmt with a
ThreadLocal<SimpleDateFormat> and use its formatter in Tree.log(), preserving
the current timestamp format and log output.

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Duplication silently succeeds with an unconfigured container on config-load failure.

If the copied config is empty/null or fails to parse, the catch/empty-content branch just logs a warning and falls through — dstContainer keeps none of srcContainer's settings (wine version, box64 preset, drives, etc.), yet the method still calls saveData() and adds it to containers. Earlier failure points in this same method (mkdirs() failing, FileUtils.copy failing) instead abort and clean up the partial directory; this path breaks that consistency and can leave a broken, unusable duplicated container silently visible to the user.

🐛 Suggested fix: abort duplication on config-load failure

         try {
             String configContent = FileUtils.readString(dstContainer.getConfigFile());
-            if (configContent != null && !configContent.trim().isEmpty()) {
-                JSONObject data = new JSONObject(configContent);
-                data.put("id", newId);
-                dstContainer.loadData(data);
-            }
+            if (configContent == null || configContent.trim().isEmpty()) {
+                Log.w("ContainerManager", "Duplicated container config is empty for " + newId + ", aborting");
+                FileUtils.delete(dstDir);
+                return;
+            }
+            JSONObject data = new JSONObject(configContent);
+            data.put("id", newId);
+            dstContainer.loadData(data);
         } catch (Exception e) {
             Log.w("ContainerManager", "Could not load config of duplicated container " + newId + ": " + e.getMessage());
+            FileUtils.delete(dstDir);
+            return;
         }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	// The source root dir (including its .container config file) was copied above.
	// Load the full copied config so every setting is preserved, instead of
	// copying a hand-picked subset of fields.
	try {
	String configContent = FileUtils.readString(dstContainer.getConfigFile());
	if (configContent != null && !configContent.trim().isEmpty()) {
	JSONObject data = new JSONObject(configContent);
	data.put("id", newId);
	dstContainer.loadData(data);
	}
	} catch (Exception e) {
	Log.w("ContainerManager", "Could not load config of duplicated container " + newId + ": " + e.getMessage());
	}
	dstContainer.setName(srcContainer.getName()+" ("+context.getString(R.string.copy)+")");
	// The source root dir (including its .container config file) was copied above.
	// Load the full copied config so every setting is preserved, instead of
	// copying a hand-picked subset of fields.
	try {
	String configContent = FileUtils.readString(dstContainer.getConfigFile());
	if (configContent == null || configContent.trim().isEmpty()) {
	Log.w("ContainerManager", "Duplicated container config is empty for " + newId + ", aborting");
	FileUtils.delete(dstDir);
	return;
	}
	JSONObject data = new JSONObject(configContent);
	data.put("id", newId);
	dstContainer.loadData(data);
	} catch (Exception e) {
	Log.w("ContainerManager", "Could not load config of duplicated container " + newId + ": " + e.getMessage());
	FileUtils.delete(dstDir);
	return;
	}
	dstContainer.setName(srcContainer.getName()+" ("+context.getString(R.string.copy)+")");

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/com/winlator/container/ContainerManager.java` around lines
210 - 225, Make config loading a required step in the container duplication
flow. In the duplication method around dstContainer.loadData, treat null/blank
config content, JSON parsing errors, and loadData failures as duplication
failures: log the error, remove the partially created destination directory
using the existing cleanup path, and return without calling saveData() or adding
dstContainer to containers. Preserve the existing successful path and align
failure handling with mkdirs() and FileUtils.copy failures.

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Never report more GPU memory than physical RAM.

The 2048 MB floor makes a 1 GB device advertise 2 GB for both DXGI memory limits, encouraging guest allocations the device cannot back. Remove the floor or retain the 70% cap without exceeding totalMb.

Proposed fix

-            return Math.max(2048L, totalMb * 70 / 100);
+            return totalMb * 70 / 100;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	/** ~70% of physical RAM in MB (floor 2048), or 0 if it can't be read. */
	private static long deviceMemoryCapMb(Context context) {
	try {
	ActivityManager am = (ActivityManager) context.getSystemService(Context.ACTIVITY_SERVICE);
	if (am == null) return 0;
	ActivityManager.MemoryInfo mi = new ActivityManager.MemoryInfo();
	am.getMemoryInfo(mi);
	long totalMb = mi.totalMem / (1024L * 1024L);
	if (totalMb <= 0) return 0;
	return Math.max(2048L, totalMb * 70 / 100);
	/** ~70% of physical RAM in MB (floor 2048), or 0 if it can't be read. */
	private static long deviceMemoryCapMb(Context context) {
	try {
	ActivityManager am = (ActivityManager) context.getSystemService(Context.ACTIVITY_SERVICE);
	if (am == null) return 0;
	ActivityManager.MemoryInfo mi = new ActivityManager.MemoryInfo();
	am.getMemoryInfo(mi);
	long totalMb = mi.totalMem / (1024L * 1024L);
	if (totalMb <= 0) return 0;
	return totalMb * 70 / 100;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/com/winlator/core/DXVKHelper.java` around lines 118 - 127,
Update deviceMemoryCapMb so its returned cap never exceeds physical RAM: remove
the 2048 MB floor and retain only the 70%-of-totalMb calculation, while
preserving the existing zero-value handling for unavailable or invalid memory
data.

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Portuguese literals in the default (English) resource file.

Several new default values are Portuguese rather than English: destination_game_hub/game_hub_title = "Loja" (Lines 103‑104), game_hub_custom_stores = "Lojas personalizadas", game_hub_add_store = "Adicionar loja", game_hub_remove_store = "Remover loja" (Lines 125‑127), and tab_store = "Loja" (Line 135). Users on any non‑pt‑BR locale will see Portuguese here. Put English in the default file and the Portuguese in values-pt-rBR/strings.xml.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/res/values/strings.xml` around lines 103 - 127, Replace the
Portuguese literals in the default strings resource for destination_game_hub,
game_hub_title, game_hub_custom_stores, game_hub_add_store,
game_hub_remove_store, and tab_store with English translations, and add the
current Portuguese values to the corresponding keys in
values-pt-rBR/strings.xml.

[cubic-dev-ai]

40 issues found across 124 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="app/src/main/res/values/strings.xml">

<violation number="1" location="app/src/main/res/values/strings.xml:103">
P0: Several new strings use Portuguese values in the default locale (`res/values/strings.xml`), which is the fallback locale for all languages. This means users of any language other than pt-BR will see "Loja", "Lojas personalizadas", "Adicionar loja", "Remover loja" instead of English text. The existing pt-BR file at `values-pt-rBR/strings.xml` already contains translations for other strings — these should use English here and be added to the pt-BR file instead.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/custom/CustomStoreConfig.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/custom/CustomStoreConfig.kt:66">
P1: API tokens are persisted in plaintext as part of the config blob, so a local data extraction exposes credentials for third-party store accounts. Keeping `authToken` out of the JSON payload and storing it via encrypted storage (Keystore-backed) would reduce credential leakage risk.</violation>

<violation number="2" location="app/src/main/java/app/gamenative/gamehub/custom/CustomStoreConfig.kt:113">
P2: Malformed config JSON is silently treated as an empty list, which can turn a transient parse issue into permanent data loss on the next save/remove. Propagating or surfacing parse errors (instead of defaulting to `emptyList`) would prevent accidental wipe of user store configurations.</violation>
</file>

<file name="app/src/main/java/app/gamenative/utils/ManifestBulkInstaller.kt">

<violation number="1" location="app/src/main/java/app/gamenative/utils/ManifestBulkInstaller.kt:68">
P1: Bulk install can ignore coroutine cancellation and keep downloading/installing entries after the caller is cancelled. This comes from wrapping `installManifestEntry` in `runCatching` without rethrowing `CancellationException`; consider rethrowing cancellation before counting it as a normal failure.</violation>
</file>

<file name="app/src/main/java/app/gamenative/ui/screen/login/LoginBackgroundVideo.kt">

<violation number="1" location="app/src/main/java/app/gamenative/ui/screen/login/LoginBackgroundVideo.kt:97">
P1: Changing videoUri or soundOn can leave the background view attached to a stale/released ExoPlayer, so the new media state may not render or play. This happens because player assignment is done only in AndroidView.factory; adding an update block to rebind `player` each recomposition would keep PlayerView in sync.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/GameLibraryRepository.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/GameLibraryRepository.kt:65">
P1: Concurrent metadata updates can drop previously written fields for the same game. The current `ConcurrentHashMap` usage is thread-safe per operation, but each setter performs a non-atomic read-modify-write; using `compute` (or another atomic update path) for each setter would preserve all fields under races.</violation>
</file>

<file name="app/src/main/java/com/winlator/contents/ContentsManager.java">

<violation number="1" location="app/src/main/java/com/winlator/contents/ContentsManager.java:574">
P1: If entryName is null the method NPEs on entryName.toLowerCase() despite the new null guard. The guard only covers the (Default) stripping step, not the rest of the method. Add an early return when entryName is null to make the guard complete.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/DelegatingStoreProvider.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/DelegatingStoreProvider.kt:47">
P1: Authentication cancellation can be misreported as an auth error because `runCatching` also catches coroutine cancellation. Using explicit `try/catch` and rethrowing `CancellationException` keeps structured concurrency and avoids false `StoreConnectionState.Error` updates.</violation>
</file>

<file name="app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupEmulation.kt">

<violation number="1" location="app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupEmulation.kt:109">
P1: Bulk-download can crash instead of showing a failure state when manifest loading throws, because the new `try/finally` clears UI state but does not catch exceptions from `ManifestBulkInstaller.installAll`. Handling the failure path locally (and returning early) would keep Settings responsive and provide user feedback.</violation>
</file>

<file name="app/src/main/java/app/gamenative/MainActivity.kt">

<violation number="1" location="app/src/main/java/app/gamenative/MainActivity.kt:648">
P1: Orientation constraints can be broadened incorrectly for mixed 3-orientation sets, so the app may rotate into a disallowed orientation. This comes from mapping any `conformTo.size >= 3` to `SCREEN_ORIENTATION_FULL_SENSOR` before the manual allowlist-based selection runs.</violation>
</file>

<file name="app/src/main/java/com/winlator/core/envvars/EnvVarInfo.kt">

<violation number="1" location="app/src/main/java/com/winlator/core/envvars/EnvVarInfo.kt:231">
P2: The new `FD_DEV_FEATURES` entry will not be used because a second `FD_DEV_FEATURES` key exists later in the same `KNOWN_ENV_VARS` map and overrides it. This can mislead users and future maintainers about which selection type/value set is actually active; consider keeping only one definition.</violation>

<violation number="2" location="app/src/main/java/com/winlator/core/envvars/EnvVarInfo.kt:274">
P2: `VKD3D_CONFIG` is defined twice in the same map, so the later existing entry overrides this newly added one. The UI/validation behavior from this block won’t apply, which can silently break the intended per-flag tuning.</violation>
</file>

<file name="app/src/main/java/app/gamenative/ui/screen/gamehub/CustomStoreDialog.kt">

<violation number="1" location="app/src/main/java/app/gamenative/ui/screen/gamehub/CustomStoreDialog.kt:42">
P2: The API token is persisted in saveable UI state, so sensitive auth data survives process recreation in plain saved-state flow. Using non-saveable state for `authToken` avoids persisting secrets beyond the current session.</violation>

<violation number="2" location="app/src/main/java/app/gamenative/ui/screen/gamehub/CustomStoreDialog.kt:137">
P2: Extra headers cannot be entered one-per-line as the UI text describes, because the shared `Field` forces a single-line text box for all inputs. Consider supporting multiline for `extraHeaders` (e.g., a `singleLine = false` path) so this config format is actually editable.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/DataStoreGameLibraryRepository.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/DataStoreGameLibraryRepository.kt:24">
P2: Metadata reads can fail hard on transient DataStore read errors because `data` is consumed without `catch`, so the flow may terminate and `get()` may throw instead of returning fallback state. Consider handling `IOException` on reads (emit empty preferences, rethrow others) before parsing.</violation>

<violation number="2" location="app/src/main/java/app/gamenative/gamehub/DataStoreGameLibraryRepository.kt:77">
P1: A parse failure currently collapses to `emptyMap()`, which silently drops all favorites/last-played/profile metadata instead of isolating the bad data. This makes one malformed payload a full metadata reset risk; consider per-entry recovery or explicit corruption handling instead of blanket empty fallback.</violation>
</file>

<file name="app/src/main/java/app/gamenative/utils/TelemetryCollector.kt">

<violation number="1" location="app/src/main/java/app/gamenative/utils/TelemetryCollector.kt:62">
P2: A quick start/stop can leave a false `.running` marker because marker creation happens after session state is already cleared. Guarding marker write with the current session check avoids recording crashes for sessions that already stopped.</violation>

<violation number="2" location="app/src/main/java/app/gamenative/utils/TelemetryCollector.kt:104">
P1: Crash telemetry can overcount because `.running` deletion is asynchronous and may not execute before process teardown. Moving marker cleanup to a synchronous step in `stop` would keep crash detection aligned with real unclean exits.</violation>
</file>

<file name="app/src/main/java/com/winlator/xserver/XClientRequestHandler.java">

<violation number="1" location="app/src/main/java/com/winlator/xserver/XClientRequestHandler.java:479">
P1: When malformed-request recovery fails, this path still reports the request as handled, so the epoll loop can keep retrying the same broken input instead of terminating that client cleanly. Propagating an `IOException` here would let `XConnectorEpoll` kill only the offending connection and avoid repeated failure loops.</violation>
</file>

<file name="app/src/main/java/app/gamenative/service/gog/GOGDownloadManager.kt">

<violation number="1" location="app/src/main/java/app/gamenative/service/gog/GOGDownloadManager.kt:1664">
P1: The new `resolveInsideInstallDir` method guards file writes against path traversal, but `createDirectoriesAndLinks` (which also processes untrusted manifest paths) still uses `File(installDir, relPath)` directly for both directories and symlinks. A malicious manifest with `../../malicious` as a directory or link path bypasses this protection. Consider applying `resolveInsideInstallDir` consistently to all manifest-derived paths, including in `createDirectoriesAndLinks`.</violation>
</file>

<file name="app/src/main/java/app/gamenative/ui/screen/library/LibraryScreen.kt">

<violation number="1" location="app/src/main/java/app/gamenative/ui/screen/library/LibraryScreen.kt:742">
P2: Library wallpaper settings can appear stuck after users change them in Layout options, because the new `PrefManager.libraryBackground*` reads are wrapped in `remember` and stop updating during recomposition. Reading these values directly each recomposition (or from observable state) keeps wallpaper visibility/media/sound in sync immediately.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/GameHubRegistrar.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/GameHubRegistrar.kt:126">
P2: Refreshing stores can leave Local games stale in the unified library because the local provider’s refresh lambda does not update the provider flow. Using a mutable flow/state-backed source for `libraryItems` and updating it inside `onRefresh` would make refresh actually propagate new local scan results.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/StoreProvider.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/StoreProvider.kt:132">
P2: Stores wired with `StoreCapabilities(canSearch = ..., requiresAuth = true)` will now advertise install/uninstall support even though `StoreProvider.install`/`uninstall` default to `notSupported`, so capability-gated UI can expose actions that always fail at runtime. Default these capability flags to `false` so support is opt-in per provider.</violation>
</file>

<file name="app/src/main/java/app/gamenative/utils/SessionLogger.kt">

<violation number="1" location="app/src/main/java/app/gamenative/utils/SessionLogger.kt:109">
P2: Concurrent logging can intermittently corrupt timestamps or crash because `Tree.log` formats dates through a shared `SimpleDateFormat` without synchronization. Using a synchronized access (or per-call formatter) keeps log formatting thread-safe.</violation>
</file>

<file name="app/src/main/java/app/gamenative/utils/CoverArtManager.kt">

<violation number="1" location="app/src/main/java/app/gamenative/utils/CoverArtManager.kt:41">
P2: Changing cover can permanently clear the existing custom image when writing the new JPEG fails, because old `cover*` files are deleted first. Writing to a temp file and only replacing old files after a successful encode would preserve the previous cover on failure.</violation>
</file>

<file name="app/src/main/java/app/gamenative/ui/component/dialog/GeneralTab.kt">

<violation number="1" location="app/src/main/java/app/gamenative/ui/component/dialog/GeneralTab.kt:248">
P2: Wine selection can revert other settings changed after this composable rendered, especially when install completes asynchronously, because the update copies from a stale captured `config` snapshot. Using the latest `state.config.value` inside `applyWineSelection` avoids clobbering unrelated fields.</violation>
</file>

<file name="app/src/main/java/com/winlator/core/DXVKHelper.java">

<violation number="1" location="app/src/main/java/com/winlator/core/DXVKHelper.java:29">
P2: Mesa shader caching will be pinned to the wrong directory in `release-gold` builds because this line hardcodes the base package data path. Using `imageFs.cache_path` keeps the cache path aligned with the current `applicationId` and the already discovered `ImageFs` root.</violation>

<violation number="2" location="app/src/main/java/com/winlator/core/DXVKHelper.java:115">
P2: VKD3D shader caching will be pinned to the base app's private directory in `release-gold` builds, so D3D12 titles won't use the intended cache. Deriving the path from `ImageFs.find(context)` avoids package-name drift across build variants.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/GameHubMappers.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/GameHubMappers.kt:49">
P2: Epic game identity can drift across syncs because the mapper uses the local Room `id` instead of Epic’s stable external key. Using `catalogId` for `GameModel.id` would keep favorites/metadata associations stable when rows are recreated.</violation>

<violation number="2" location="app/src/main/java/app/gamenative/gamehub/GameHubMappers.kt:65">
P2: Amazon game identity is currently tied to local DB `appId`, which can change when rows are recreated during library refresh. Building the hub ID from stable `productId` avoids metadata/favorite mismatches for the same entitlement.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/StoreManager.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/StoreManager.kt:49">
P2: `register()` can ignore coroutine cancellation during provider initialization, so startup/shutdown cancellation may not stop registration work. This happens because `runCatching` catches `CancellationException` and the result is dropped; rethrow cancellation and only handle non-cancellation failures.</violation>
</file>

<file name="app/src/main/java/app/gamenative/gamehub/GameModel.kt">

<violation number="1" location="app/src/main/java/app/gamenative/gamehub/GameModel.kt:49">
P2: Installed games with pending updates can be treated as not installed, which can break installed filters and UI state during migration. This comes from `isInstalled` only checking `InstallState.INSTALLED`; considering `UPDATE_AVAILABLE` as installed would keep behavior consistent.</violation>
</file>

<file name="app/src/main/java/app/gamenative/service/amazon/AmazonSdkManager.kt">

<violation number="1" location="app/src/main/java/app/gamenative/service/amazon/AmazonSdkManager.kt:92">
P2: The traversal guard still accepts paths that resolve to the SDK root itself, so a malformed manifest entry can target the cache directory as a file destination. Consider rejecting anything that is not a strict child of `sdkRoot`, and handling canonicalization failures per-file so one bad path does not abort the whole download.</violation>
</file>

<file name="app/src/main/java/app/gamenative/ui/screen/library/components/LibraryBackground.kt">

<violation number="1" location="app/src/main/java/app/gamenative/ui/screen/library/components/LibraryBackground.kt:102">
P2: Background video updates can silently break after settings/content changes because the reused `PlayerView` is never rebound to the new `ExoPlayer` instance. Adding an `update` lambda keeps `PlayerView.player` in sync with recomposed `exoPlayer` values.</violation>
</file>

<file name=".github/workflows/build-apk.yml">

<violation number="1" location=".github/workflows/build-apk.yml:19">
P2: This configuration does not preserve a full per-commit build queue on active branches; intermediate pending runs can be dropped under bursty pushes. If every commit must build, the concurrency strategy should be changed to one that does not rely on default pending-slot behavior.</violation>

<violation number="2" location=".github/workflows/build-apk.yml:104">
P2: Manual runs on non-`claude/*` branches still enter the release job, which can create/update debug releases for mainline branches. Tightening the condition to branch scope keeps behavior aligned with the stated release isolation.</violation>
</file>

<file name="app/src/main/java/com/winlator/container/ContainerManager.java">

<violation number="1" location="app/src/main/java/com/winlator/container/ContainerManager.java:221">
P2: A failed config read during duplication now produces a partially default container instead of preserving source settings, because the exception path logs and continues to `saveData()`. Consider aborting duplication (and cleaning `dstDir`) when config load fails so users don't get a silently misconfigured copy.</violation>
</file>

<file name="app/src/main/java/app/gamenative/service/epic/EpicDownloadManager.kt">

<violation number="1" location="app/src/main/java/app/gamenative/service/epic/EpicDownloadManager.kt:1309">
P2: Canonical path resolution is unguarded, so filesystem canonicalization errors can escape before allocation error handling and terminate this coroutine unexpectedly. Catching canonicalization failures inside `resolveInsideInstallDir` and returning null keeps this path in controlled failure handling.</violation>
</file>

<file name="app/src/main/java/app/gamenative/lan/LanRoomManager.kt">

<violation number="1" location="app/src/main/java/app/gamenative/lan/LanRoomManager.kt:489">
P2: After a join is denied, fails, or the host closes the room, the multicast lock can remain held and keep Wi‑Fi resources active until a manual stop. Releasing the lock on non-room terminal transitions in `joinRoom` avoids this battery/network leak.</violation>
</file>

<file name="app/src/main/cpp/virglrenderer/CMakeLists.txt">

<violation number="1" location="app/src/main/cpp/virglrenderer/CMakeLists.txt:57">
P2: Missing -Wl,-z,common-page-size=16384 alongside max-page-size. The official Android docs for 16 KB page size support recommend both flags for NDK r27 and lower. Without common-page-size, the ELF program header p_align field may not be set to 16 KB, which can cause the loader to fail on 16 KB page size devices. Several targets in this repo (asurfacerenderer, evshim, steambootstrap) already set both flags.</violation>
</file>

<sub>Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.

Re-trigger cubic</sub>

[cubic-dev-ai]

P0: Several new strings use Portuguese values in the default locale (res/values/strings.xml), which is the fallback locale for all languages. This means users of any language other than pt-BR will see "Loja", "Lojas personalizadas", "Adicionar loja", "Remover loja" instead of English text. The existing pt-BR file at values-pt-rBR/strings.xml already contains translations for other strings — these should use English here and be added to the pt-BR file instead.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/res/values/strings.xml, line 103:

<comment>Several new strings use Portuguese values in the default locale (`res/values/strings.xml`), which is the fallback locale for all languages. This means users of any language other than pt-BR will see "Loja", "Lojas personalizadas", "Adicionar loja", "Remover loja" instead of English text. The existing pt-BR file at `values-pt-rBR/strings.xml` already contains translations for other strings — these should use English here and be added to the pt-BR file instead.</comment>

<file context>
@@ -100,13 +100,39 @@
     <string name="confirm_delete">Confirm Deletion</string>
     <string name="destination_library">Library</string>
     <string name="destination_downloads">Downloads &amp; Storage</string>
+    <string name="destination_game_hub">Loja</string>
+    <string name="game_hub_title">Loja</string>
+    <string name="game_hub_all_sources">All stores</string>
</file context>

[cubic-dev-ai]

P1: API tokens are persisted in plaintext as part of the config blob, so a local data extraction exposes credentials for third-party store accounts. Keeping authToken out of the JSON payload and storing it via encrypted storage (Keystore-backed) would reduce credential leakage risk.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/java/app/gamenative/gamehub/custom/CustomStoreConfig.kt, line 66:

<comment>API tokens are persisted in plaintext as part of the config blob, so a local data extraction exposes credentials for third-party store accounts. Keeping `authToken` out of the JSON payload and storing it via encrypted storage (Keystore-backed) would reduce credential leakage risk.</comment>

<file context>
@@ -0,0 +1,128 @@
+        .put("authType", authType.name)
+        .put("authHeaderName", authHeaderName)
+        .put("authScheme", authScheme)
+        .put("authToken", authToken)
+        .put("httpMethod", httpMethod)
+        .put("libraryEndpoint", libraryEndpoint)
</file context>

[cubic-dev-ai]

P1: Bulk install can ignore coroutine cancellation and keep downloading/installing entries after the caller is cancelled. This comes from wrapping installManifestEntry in runCatching without rethrowing CancellationException; consider rethrowing cancellation before counting it as a normal failure.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/java/app/gamenative/utils/ManifestBulkInstaller.kt, line 68:

<comment>Bulk install can ignore coroutine cancellation and keep downloading/installing entries after the caller is cancelled. This comes from wrapping `installManifestEntry` in `runCatching` without rethrowing `CancellationException`; consider rethrowing cancellation before counting it as a normal failure.</comment>

<file context>
@@ -0,0 +1,80 @@
+        var failed = 0
+        jobs.forEachIndexed { i, (entry, isDriver, type) ->
+            onProgress(Progress(entry.name, i + 1, jobs.size, 0f))
+            val result = runCatching {
+                ManifestInstaller.installManifestEntry(context, entry, isDriver, type) { f ->
+                    onProgress(Progress(entry.name, i + 1, jobs.size, f))
</file context>

[cubic-dev-ai]

P1: Changing videoUri or soundOn can leave the background view attached to a stale/released ExoPlayer, so the new media state may not render or play. This happens because player assignment is done only in AndroidView.factory; adding an update block to rebind player each recomposition would keep PlayerView in sync.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/java/app/gamenative/ui/screen/login/LoginBackgroundVideo.kt, line 97:

<comment>Changing videoUri or soundOn can leave the background view attached to a stale/released ExoPlayer, so the new media state may not render or play. This happens because player assignment is done only in AndroidView.factory; adding an update block to rebind `player` each recomposition would keep PlayerView in sync.</comment>

<file context>
@@ -0,0 +1,99 @@
+                )
+            }
+        },
+        modifier = modifier,
+    )
+}
</file context>

[cubic-dev-ai]

P1: Concurrent metadata updates can drop previously written fields for the same game. The current ConcurrentHashMap usage is thread-safe per operation, but each setter performs a non-atomic read-modify-write; using compute (or another atomic update path) for each setter would preserve all fields under races.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/java/app/gamenative/gamehub/GameLibraryRepository.kt, line 65:

<comment>Concurrent metadata updates can drop previously written fields for the same game. The current `ConcurrentHashMap` usage is thread-safe per operation, but each setter performs a non-atomic read-modify-write; using `compute` (or another atomic update path) for each setter would preserve all fields under races.</comment>

<file context>
@@ -0,0 +1,82 @@
+    override suspend fun get(gameId: String): GameHubMetadata? = store[gameId]
+
+    override suspend fun setFavorite(gameId: String, favorite: Boolean) {
+        store[gameId] = (store[gameId] ?: GameHubMetadata(gameId)).copy(favorite = favorite)
+        publish()
+    }
</file context>

[cubic-dev-ai]

P2: Epic game identity can drift across syncs because the mapper uses the local Room id instead of Epic’s stable external key. Using catalogId for GameModel.id would keep favorites/metadata associations stable when rows are recreated.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/java/app/gamenative/gamehub/GameHubMappers.kt, line 49:

<comment>Epic game identity can drift across syncs because the mapper uses the local Room `id` instead of Epic’s stable external key. Using `catalogId` for `GameModel.id` would keep favorites/metadata associations stable when rows are recreated.</comment>

<file context>
@@ -0,0 +1,76 @@
+)
+
+fun EpicGame.toGameModel(): GameModel = GameModel(
+    id = GameModel.buildId(GameSource.EPIC, id.toString()),
+    name = title.ifEmpty { appName },
+    source = GameSource.EPIC,
</file context>

Suggested change

	id = GameModel.buildId(GameSource.EPIC, id.toString()),
	id = GameModel.buildId(GameSource.EPIC, catalogId.ifEmpty { id.toString() }),

[cubic-dev-ai]

P2: Canonical path resolution is unguarded, so filesystem canonicalization errors can escape before allocation error handling and terminate this coroutine unexpectedly. Catching canonicalization failures inside resolveInsideInstallDir and returning null keeps this path in controlled failure handling.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/java/app/gamenative/service/epic/EpicDownloadManager.kt, line 1309:

<comment>Canonical path resolution is unguarded, so filesystem canonicalization errors can escape before allocation error handling and terminate this coroutine unexpectedly. Catching canonicalization failures inside `resolveInsideInstallDir` and returning null keeps this path in controlled failure handling.</comment>

<file context>
@@ -1276,6 +1299,23 @@ class EpicDownloadManager @Inject constructor(
+     * directory (path traversal / "zip slip"). Returns null if the path escapes.
+     */
+    private fun resolveInsideInstallDir(installDir: File, relativePath: String): File? {
+        val installRoot = installDir.canonicalPath
+        val resolved = File(installDir, relativePath).canonicalFile
+        return if (resolved.path == installRoot || resolved.path.startsWith(installRoot + File.separator)) {
</file context>

[cubic-dev-ai]

P2: After a join is denied, fails, or the host closes the room, the multicast lock can remain held and keep Wi‑Fi resources active until a manual stop. Releasing the lock on non-room terminal transitions in joinRoom avoids this battery/network leak.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/java/app/gamenative/lan/LanRoomManager.kt, line 489:

<comment>After a join is denied, fails, or the host closes the room, the multicast lock can remain held and keep Wi‑Fi resources active until a manual stop. Releasing the lock on non-room terminal transitions in `joinRoom` avoids this battery/network leak.</comment>

<file context>
@@ -0,0 +1,599 @@
+                                }
+                            }
+                        }
+                        if (_status.value == Status.JOINED) {
+                            _status.value = Status.IDLE
+                            _players.value = emptyList()
</file context>

[cubic-dev-ai]

P2: Manual runs on non-claude/* branches still enter the release job, which can create/update debug releases for mainline branches. Tightening the condition to branch scope keeps behavior aligned with the stated release isolation.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/build-apk.yml, line 104:

<comment>Manual runs on non-`claude/*` branches still enter the release job, which can create/update debug releases for mainline branches. Tightening the condition to branch scope keeps behavior aligned with the stated release isolation.</comment>

<file context>
@@ -0,0 +1,150 @@
+  # runs so it never touches main's releases.
+  release:
+    needs: build
+    if: startsWith(github.ref_name, 'claude/') || github.event_name == 'workflow_dispatch'
+    runs-on: ubuntu-latest
+    permissions:
</file context>

[cubic-dev-ai]

P2: Missing -Wl,-z,common-page-size=16384 alongside max-page-size. The official Android docs for 16 KB page size support recommend both flags for NDK r27 and lower. Without common-page-size, the ELF program header p_align field may not be set to 16 KB, which can cause the loader to fail on 16 KB page size devices. Several targets in this repo (asurfacerenderer, evshim, steambootstrap) already set both flags.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/cpp/virglrenderer/CMakeLists.txt, line 57:

<comment>Missing -Wl,-z,common-page-size=16384 alongside max-page-size. The official Android docs for 16 KB page size support recommend both flags for NDK r27 and lower. Without common-page-size, the ELF program header p_align field may not be set to 16 KB, which can cause the loader to fail on 16 KB page size devices. Several targets in this repo (asurfacerenderer, evshim, steambootstrap) already set both flags.</comment>

<file context>
@@ -52,4 +52,6 @@ target_link_libraries(virglrenderer
\ No newline at end of file
+                      GLESv3)
+# Align ELF LOAD segments to 16 KB for Android 15+ devices with 16 KB page size.
+target_link_options(virglrenderer PRIVATE -Wl,-z,max-page-size=16384)
</file context>

Suggested change

	target_link_options(virglrenderer PRIVATE -Wl,-z,max-page-size=16384)
	target_link_options(virglrenderer PRIVATE -Wl,-z,max-page-size=16384 -Wl,-z,common-page-size=16384)

[phobos665]

What on earth.