fix: handle steam 0B depot download (fix recent update of Vampire Survivors DLC)

[joshuatam]

Description

Fix game like Vampire Survivors DLC that has 0B depot updated recently.

Recording

Type of Change

• Bug fix
• Performance / stability improvement
• Compatibility improvements
• Other (requires prior approval)

Checklist

• If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
• This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
• I have attached a recording of the change.
• I have read and agree to the contribution guidelines in CONTRIBUTING.md.

---

Summary by cubic

Fixes Steam 0B depot handling so DLC like Vampire Survivors installs correctly after the recent update. Updates in.dragonbra:javasteam for compatibility.

• Bug Fixes

  • Removed the guard that skipped 0‑byte manifest depots, enabling valid “empty” depots to download.
  • Updated DepotFilteringTest to accept 0‑byte depots.

• Dependencies

  • Bumped in.dragonbra:javasteam to 1.8.0.1-20-SNAPSHOT and updated local JAR paths.

^{Written for commit 1fcc4fc. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes

  • Improved depot eligibility detection so depots with zero-sized/zero-download manifests are treated as downloadable when other eligibility signals apply (e.g., unlocked branches and shared installations).

• Chores

  • Updated bundled dependency snapshots to the latest available versions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8196c924-c61d-4f2e-bdfd-0509123aef8a

📥 Commits

Reviewing files that changed from the base of the PR and between b32f9c8 and 1fcc4fc.

📒 Files selected for processing (1)

• app/src/test/java/app/gamenative/service/DepotFilteringTest.kt

---

📝 Walkthrough

Walkthrough

Bumps the bundled JavaSteam JARs from -18-SNAPSHOT to -20-SNAPSHOT in app/build.gradle.kts and updates the version catalog entry in gradle/libs.versions.toml from 1.8.0.1-19-SNAPSHOT to 1.8.0.1-20-SNAPSHOT. In SteamService.filterForDownloadableDepots, the stale-manifest early-return is replaced by a hasContent boolean that also passes depots with sharedInstall or hasSteamUnlockedBranch with non-empty encryptedManifests. Test expectations are updated accordingly.

Changes

JavaSteam upgrade and depot filtering fix

Layer / File(s)	Summary
JavaSteam -20-SNAPSHOT dependency bump gradle/libs.versions.toml, app/build.gradle.kts	Version catalog updated from 1.8.0.1-19-SNAPSHOT to 1.8.0.1-20-SNAPSHOT; local JAR paths in localBuild block updated from -18-SNAPSHOT to -20-SNAPSHOT.
filterForDownloadableDepots hasContent gating and test app/src/main/java/app/gamenative/service/SteamService.kt, app/src/test/java/app/gamenative/service/DepotFilteringTest.kt	hasContent now also returns true for depot.sharedInstall == true or hasSteamUnlockedBranch && encryptedManifests.isNotEmpty(), replacing the prior strict zero-size/zero-download exclusion. Test case depot with 0-byte manifest renamed and assertion changed from rejection to acceptance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• utkarshdalal/GameNative#1209: The updated hasContent logic directly addresses the aggressive stale-PICS filtering that rejected valid depots with zero-size manifests, allowing games like Don't Starve Together to properly include previously-filtered shared install and SteamUnlocked encrypted depots.

Possibly related PRs

• utkarshdalal/GameNative#1399: Both PRs change SteamService.filterForDownloadableDepots depot-eligibility logic—main PR adjusts the "has content" zero-manifest gating, while the retrieved PR adds an early rejection for depots with realm == SteamChina.
• utkarshdalal/GameNative#369: Both PRs modify the javasteam dependency version in gradle/libs.versions.toml.
• utkarshdalal/GameNative#929: Both PRs modify SteamService.filterForDownloadableDepots stale manifest gating so depots with zero-byte manifests are treated as eligible rather than rejected.

Suggested reviewers

• utkarshdalal

Poem

🐇 A bunny hops through depot land,
Where manifests were once too bland—
SharedInstall and encrypted keys
Now pass through filters with great ease!
JavaSteam -20 takes the stage,
A brand new snapshot on the page. 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main bug fix—handling 0B Steam depots for Vampire Survivors DLC—which aligns with the primary objective of this changeset.
Description check	✅ Passed	The PR description fully follows the template with all required sections completed: Description, Recording, Type of Change (bug fix and compatibility improvements selected), and Checklist items marked as complete.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 3 files

_{Re-trigger cubic}

[utkarshdalal]

I think instead of doing this it is safer to:

1. Take in isDlc = false param for the method
2. On line 1016, pass in isDlc = true
3. Change the code to

val isDlcDepot = isDlc || depot.dlcAppId != INVALID_APP_ID
...
if (depot.manifests.isNotEmpty() && (!isDlcDepot && depot.manifests.values.all { it.size == 0L && it.download == 0L }))

Thoughts?