Repository navigation
fix(admission): start on an admissible ruling even when the review removed format-ok - #174
Merged
Merged
Conversation
…moved format-ok The review may remove format-ok in the same safe output that labels admissible; the admission's job condition required that label, so its run was skipped without an error and the issue stayed admissible and still (#171). The condition guards nothing the job does not check: the intake comment carries a candidate block under the format-ok verdict only, and the first step refuses a comment without one. Closes #173 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…st line only A needs-changes comment quotes the manifest in its errors, and a manifest key can spell a whole candidate block: with the job no longer conditioned on format-ok, a contributor timing an edit against the review could have had that block admitted. The intake writes its block as the last line under format-ok and under no other verdict; the admission now reads that line and nothing else. Refs #173 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
On #171 the review labelled
admissibleand removedformat-okin the same safe output. The admission's job condition requiredformat-ok, so its run was skipped without an error and the issue stayed open, admissible and still.Changes
admission.yml: the job no longer requiresformat-okon the issue.scripts/admission.py: the candidate block is read from the intake comment's last line only. The intake writes it there underformat-okand under no other verdict; every other verdict ends with a fixed sentence.format-okends with a block, with the mark fed through every contributor-derived channel (form, validation and derivation errors, smoke output).Why the second change
The security review found that dropping the condition alone opened a path: a
needs-changescomment quotes unknown manifest keys raw, a manifest key can spell a whole candidate block, and the admission took the last block found anywhere in the comment. A contributor timing an edit against the review could have had that block admitted. Reading the last line only closes it; the reviewer's proof of concept is now refused.Reviewed by the code-reviewer and security-review sub-agents, twice (before and after that fix): nothing left to fix.
🤖 Generated with Claude Code