Skip to content

fix(admission): start on an admissible ruling even when the review removed format-ok - #174

Merged
using-system merged 2 commits into
mainfrom
fix/admission-without-format-ok
Nov 11, 2026
Merged

using-system merged 2 commits into
mainfrom
fix/admission-without-format-ok

Conversation

@using-system

Copy link
Copy Markdown
Owner

Closes #173

On #171 the review labelled admissible and removed format-ok in the same safe output. The admission's job condition required format-ok, so its run was skipped without an error and the issue stayed open, admissible and still.

Changes

  • admission.yml: the job no longer requires format-ok on the issue.
  • scripts/admission.py: the candidate block is read from the intake comment's last line only. The intake writes it there under format-ok and under no other verdict; every other verdict ends with a fixed sentence.
  • tests: a block quoted by an error is refused, a block that is not the last line is refused, and no verdict other than format-ok ends with a block, with the mark fed through every contributor-derived channel (form, validation and derivation errors, smoke output).

Why the second change

The security review found that dropping the condition alone opened a path: a needs-changes comment quotes unknown manifest keys raw, a manifest key can spell a whole candidate block, and the admission took the last block found anywhere in the comment. A contributor timing an edit against the review could have had that block admitted. Reading the last line only closes it; the reviewer's proof of concept is now refused.

Reviewed by the code-reviewer and security-review sub-agents, twice (before and after that fix): nothing left to fix.

🤖 Generated with Claude Code

using-system and others added 2 commits November 11, 2026 14:57
…moved format-ok

The review may remove format-ok in the same safe output that labels
admissible; the admission's job condition required that label, so its
run was skipped without an error and the issue stayed admissible and
still (#171). The condition guards nothing the job does not check: the
intake comment carries a candidate block under the format-ok verdict
only, and the first step refuses a comment without one.

Closes #173

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…st line only

A needs-changes comment quotes the manifest in its errors, and a
manifest key can spell a whole candidate block: with the job no longer
conditioned on format-ok, a contributor timing an edit against the
review could have had that block admitted. The intake writes its block
as the last line under format-ok and under no other verdict; the
admission now reads that line and nothing else.

Refs #173

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@using-system
using-system merged commit 8ede222 into main Nov 11, 2026
1 check passed
@using-system
using-system deleted the fix/admission-without-format-ok branch November 11, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(admission): start on an admissible ruling even when the review removed format-ok

1 participant