Clamp wait_for_agents timeout to the tool's ceiling - #1165
Open
bearsyankees wants to merge 1 commit into
Open
Conversation
Models sometimes request very large wait timeouts (hours or more). The raw value went straight into the inner asyncio.wait_for, so the SDK's tool-call ceiling fired first and aborted the call instead of returning the clean timeout payload that tells the agent to keep working or finish. Clamp the requested value into [1s, 300s], wait on the clamped value, and echo it back.
Contributor
Greptile SummaryThis PR clamps
Confidence Score: 5/5The PR appears safe to merge with no concrete correctness or security defects identified. The timeout is normalized before reaching Important Files Changed
Reviews (1): Last reviewed commit: "Clamp wait_for_agents timeout to the too..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models sometimes request very large wait timeouts (hours or more). The raw value went straight into the inner asyncio.wait_for, so the SDK's tool-call ceiling fired first and aborted the call instead of returning the clean timeout payload that tells the agent to keep working or finish. Clamp the requested value into [1s, 300s], wait on the clamped value, and echo it back.