Repository navigation
Stop re-registering the WSL interop binfmt handler - #24
Merged
Merged
Conversation
WSL 3 registers the WSLInterop handler itself and mounts a read-only file over /proc/sys/fs/binfmt_misc/status. systemd-binfmt can no longer flush rules, exits 1, and switch-to-configuration fails with status 4. Drop wsl.interop.register so NixOS-WSL uses its default (the existing registration). WSLInterop was the only binfmt registration, so systemd-binfmt.service is no longer installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change matches the pinned NixOS-WSL default and resolves the documented activation failure.
Review effort: Balanced
Findings: None
What changed in this PR
Removes redundant WSL interop registration to prevent systemd-binfmt failures on WSL 3.
Changes:
- Relies on NixOS-WSL’s default existing interop handler.
- Documents why explicit registration must remain disabled.
| File | Description |
|---|---|
systems/wsl/configuration.nix |
Removes explicit binfmt registration and explains the WSL 3 constraint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WSL 3 registers the WSLInterop handler itself and mounts a read-only file over /proc/sys/fs/binfmt_misc/status. systemd-binfmt can no longer flush rules, exits 1, and switch-to-configuration fails with status 4.
Drop wsl.interop.register so NixOS-WSL uses its default (the existing registration). WSLInterop was the only binfmt registration, so systemd-binfmt.service is no longer installed.