Skip to content

fix: avoid over-redacting ordinary urls - #45

Merged
mic1on merged 1 commit into
mainfrom
fix/scope-single-segment-redaction
Jul 11, 2026
Merged

fix: avoid over-redacting ordinary urls#45
mic1on merged 1 commit into
mainfrom
fix/scope-single-segment-redaction

Conversation

@mic1on

@mic1on mic1on commented Jul 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Keep ordinary single-segment URLs such as https://example.com/docs visible in redacted error messages.
  • Continue redacting known provider path secrets and sensitive-looking custom single-segment notification paths.
  • Add regression coverage for ordinary single-segment URLs and opaque custom token-like paths.

Closes #44

Test Coverage

  • Added coverage that ordinary single-segment URLs remain unchanged.
  • Extended custom base URL redaction coverage for token-like single-segment paths.

Test plan

  • uv run --group dev pytest -q tests/test_notification.py -k redaction (2 passed)
  • make lint
  • make test (103 passed)
  • make coverage (94% total coverage)
  • uv build
  • uv pip check

Keep ordinary single-segment URLs visible while still redacting sensitive-looking custom notification paths.\n\nRefs #44
@mic1on
mic1on merged commit fdf36ec into main Jul 11, 2026
3 checks passed
@mic1on
mic1on deleted the fix/scope-single-segment-redaction branch July 11, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid over-redacting ordinary single-segment URLs

1 participant