fix(unikontainers): propagate actual errors instead of masking behind ErrNotUnikernel - #960
Open
safiya2610 wants to merge 1 commit into
Open
fix(unikontainers): propagate actual errors instead of masking behind ErrNotUnikernel#960safiya2610 wants to merge 1 commit into
safiya2610 wants to merge 1 commit into
Conversation
✅ Deploy Preview for urunc canceled.
|
…ehind ErrNotUnikernel Signed-off-by: safiya2610 <lci2023053@iiitl.ac.in>
safiya2610
force-pushed
the
fix-issue-876
branch
from
August 11, 2026 22:15
ee44782 to
904d20b
Compare
|
Don't overwrite the PR template |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #876
Summary of Changes:
Updated
GetUnikernelConfigerror handling inpkg/unikontainers/unikontainers.go.Instead of masking all configuration/decoding errors into
ErrNotUnikernel, it now properly propagates the actual parsing/base64 decoding errors to the user. It only falls back to runc (viaErrNotUnikernel) specifically whenos.ErrNotExistoccurs (i.e. no configuration exists).This prevents silent failures and makes debugging malformed configurations much easier.