test(hypervisors/firecracker): Add unit test suite for Firecracker config generation - #949
Draft
safiya2610 wants to merge 1 commit into
Draft
test(hypervisors/firecracker): Add unit test suite for Firecracker config generation#949safiya2610 wants to merge 1 commit into
safiya2610 wants to merge 1 commit into
Conversation
…nfig generation Signed-off-by: safiya2610 <lci2023053@iiitl.ac.in>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Firecracker hypervisor implementation in
pkg/unikontainers/hypervisors/firecracker.gocurrently lacks unit test coverage. Since Firecracker dynamically generates a JSON configuration file (config.json) containing settings forboot-source,machine-config,network-interfaces, anddrives, a comprehensive unit test suite is needed to ensure these configurations and the resulting CLI arguments are correctly generated without regressions.Summary
This PR introduces a comprehensive table-driven unit test suite (
firecracker_test.go) for the Firecracker driver.Changes include:
TestFirecrackerBuildExecCmd: VerifiesExecCommand()by parsing the JSON file generated in/tmp/and ensuring proper translation of:vcpuandmemoryparameters into themachine-config.MonitorNetArgsintonetwork-interfaces(includingmacandhost_dev_name).MonitorBlockArgsintodrives(including correctis_root_deviceandis_read_onlystates).--no-apiand--config-file.TestFirecrackerProperties: Verifies that Firecracker properly returns capabilities likeUsesKVM()and ignores unsupportedSharedFSparameters.Testing
go test -v ./pkg/unikontainers/hypervisors/...go builddoes not break.Linked Issues
Fixes: #948