Make browser summary reports single-file - #410
Conversation
Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
1 participant
Make browser summary reports single-file.
Summary of changes
RtichokeBrowserReport.write_html()insrc/rtichoke/_report_browser.pyto embedrtichoke-viz.cssdirectly into a<style>block in the document<head>and stop copying siblingrtichoke-viz.jsandrtichoke-viz.cssassets into output directories.<link rel="stylesheet" href="./rtichoke-viz.css">from summary report HTML.rtichoke-viz.jsorrtichoke-viz.cssfiles in an output directory are neither deleted nor overwritten.src/rtichoke/_viz_browser.pycompletely unchanged so standalone proof renderer paths continue to produce and use sibling JS/CSS files as expected.tests/test_report_browser.py,tests/test_summary_report_browser.py, andtests/test_calibration_v2.pyto assert single-file output directories, inline CSS, embedded JS runtime, and safety behavior.Baseline & Final Output Measurements
Before:
After:
Savings:
Confirmations
f2cf6c5822b3ab60a03d62b3f9557719d6d8b8efsrc/rtichoke/_report_browser.py,tests/test_calibration_v2.py,tests/test_report_browser.py,tests/test_summary_report_browser.py_viz_browser.pyare unchanged.PR created automatically by Jules for task 13591626409443166625 started by @uriahf