Generalize calibration bins - #409
Conversation
- Expose `n_bins=10` on `create_calibration_curve` and `create_calibration_curve_times` as keyword-only parameter. - Align static binary calibration binning with R `dplyr::ntile()` contract. - Preserve existing adjusted-time Aalen-Johansen grouping semantics while renaming `decile` to `bin`. - Atomically rename internal deciles structures to neutral `calibration_bins_dat`. - Update canonical adapters and add comprehensive test coverage. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
- Expose `n_bins=10` on `create_calibration_curve` and `create_calibration_curve_times` as keyword-only parameter. - Align static binary calibration binning with R `dplyr::ntile()` contract. - Preserve existing adjusted-time Aalen-Johansen grouping semantics while renaming `decile` to `bin`. - Atomically rename internal deciles structures to neutral `calibration_bins_dat`. - Update canonical adapters and add comprehensive test coverage. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
- Expose `n_bins=10` on `create_calibration_curve` and `create_calibration_curve_times` as keyword-only parameter. - Wrap subpackage entry points with `functools.wraps` so top-level signature introspection exposes `*, n_bins: int = 10`. - Preserve positional compatibility on `_create_calibration_curve_list()` with `size` as the third positional parameter. - Align static binary calibration binning with R `dplyr::ntile()` contract. - Preserve existing adjusted-time Aalen-Johansen grouping semantics while renaming `decile` to integer `bin`. - Atomically rename internal deciles structures to neutral `calibration_bins_dat`. - Update canonical adapters, user guide documentation, and add comprehensive test coverage. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
1 participant
Generalizes calibration bins across
rtichoke_pythonby exposing keyword-onlyn_bins: int = 10oncreate_calibration_curveandcreate_calibration_curve_times, aligning static/non-adjusted binary calibration with Rdplyr::ntile()bucket allocation parity, preserving existing adjusted-time Aalen-Johansen grouping semantics, and atomically migrating internal terminology fromdeciles_dattocalibration_bins_dat.PR created automatically by Jules for task 6283394964679611865 started by @uriahf