Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,15 @@ jobs:
prefix = "rtichoke/_vendor/rtichoke_viz/"
required = {
f"{prefix}VENDORED_FROM",
f"{prefix}rtichoke-viz-0.20.0.tar.gz",
f"{prefix}rtichoke-viz-0.20.1.tar.gz",
f"{prefix}rtichoke-viz.js",
f"{prefix}rtichoke-viz.css",
f"{prefix}rtichoke-viz.schema.json",
f"{prefix}rtichoke-viz-v2.schema.json",
f"{prefix}rtichoke-viz-report.schema.json",
}
assert required <= names
assert f"{prefix}rtichoke-viz-0.20.0.tar.gz" not in names
assert f"{prefix}rtichoke-viz-0.19.0.tar.gz" not in names
assert f"{prefix}rtichoke-viz-0.14.0.tar.gz" not in names
PY
Expand Down
8 changes: 4 additions & 4 deletions src/rtichoke/_vendor/rtichoke_viz/VENDORED_FROM
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
repository=https://github.com/uriahf/rtichoke_viz
release=v0.20.0
source_commit=15e9712686650e23d3c79ddea99892bc5836f5e4
archive=rtichoke-viz-0.20.0.tar.gz
sha256=9a89356ffa5e72de3526f343960ad21bbc57475a3515748d846cbd447dee17d1
release=v0.20.1
source_commit=56e097ab394f3499ef5cfe791e686248df8b39f2
archive=rtichoke-viz-0.20.1.tar.gz
sha256=17aebfb05a479c3ea28855f6ca3f43cadde7b8b134a2080e309c630c63617629
Binary file not shown.
Binary file not shown.
14 changes: 10 additions & 4 deletions src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.css
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@
border-bottom: 1px solid #f3f4f6;
white-space: nowrap;
position: relative;
z-index: 0;
}

.rtichoke-performance-table__table tbody tr:hover {
Expand Down Expand Up @@ -218,6 +219,11 @@
min-width: 70px;
}

.rtichoke-performance-table__cell-text {
position: relative;
z-index: 1;
}

.rtichoke-performance-table__bar {
position: absolute;
top: 4px;
Expand All @@ -227,27 +233,27 @@
pointer-events: none;
overflow: hidden;
border-radius: 2px;
z-index: -1;
}

.rtichoke-performance-table__bar-fill {
position: absolute;
top: 0;
bottom: 0;
border-radius: 2px;
opacity: 0.25;
transition: width 0.2s ease;
}

.rtichoke-performance-table__bar-fill--positive {
background-color: #2e7559;
background-color: lightgreen;
}

.rtichoke-performance-table__bar-fill--negative {
background-color: #dc2626;
background-color: pink;
}

.rtichoke-performance-table__bar-fill--neutral {
background-color: #6b7280;
background-color: lightgrey;
}

/* Disclosure column & toggle button */
Expand Down
5 changes: 4 additions & 1 deletion src/rtichoke/_vendor/rtichoke_viz/rtichoke-viz.js
Original file line number Diff line number Diff line change
Expand Up @@ -20298,7 +20298,10 @@ var PRIMARY_METRIC_ORDER = [
];
function cell(document2, text2, className) {
const element = document2.createElement("td");
element.textContent = text2;
const contentSpan = document2.createElement("span");
contentSpan.className = "rtichoke-performance-table__cell-text";
contentSpan.textContent = text2;
element.append(contentSpan);
if (className) element.className = className;
return element;
}
Expand Down
19 changes: 10 additions & 9 deletions tests/test_rtichoke_viz_vendor.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
from pathlib import Path

_VENDOR = Path(__file__).parents[1] / "src" / "rtichoke" / "_vendor" / "rtichoke_viz"
_RELEASE_DIR = "rtichoke-viz-0.20.0"
_SHA256 = "9a89356ffa5e72de3526f343960ad21bbc57475a3515748d846cbd447dee17d1"
_SOURCE_COMMIT = "15e9712686650e23d3c79ddea99892bc5836f5e4"
_RELEASE_DIR = "rtichoke-viz-0.20.1"
_SHA256 = "17aebfb05a479c3ea28855f6ca3f43cadde7b8b134a2080e309c630c63617629"
_SOURCE_COMMIT = "56e097ab394f3499ef5cfe791e686248df8b39f2"


def test_vendored_rtichoke_viz_v0200_provenance_archive_and_schemas():
def test_vendored_rtichoke_viz_v0201_provenance_archive_and_schemas():
provenance = (_VENDOR / "VENDORED_FROM").read_text()
assert "release=v0.20.0" in provenance
assert "release=v0.20.1" in provenance
assert f"source_commit={_SOURCE_COMMIT}" in provenance
assert "archive=rtichoke-viz-0.20.0.tar.gz" in provenance
assert "archive=rtichoke-viz-0.20.1.tar.gz" in provenance
assert f"sha256={_SHA256}" in provenance

archive = _VENDOR / "rtichoke-viz-0.20.0.tar.gz"
archive = _VENDOR / "rtichoke-viz-0.20.1.tar.gz"
assert hashlib.sha256(archive.read_bytes()).hexdigest() == _SHA256
with tarfile.open(archive, "r:gz") as release:
assert set(release.getnames()) == {
Expand All @@ -30,7 +30,7 @@ def test_vendored_rtichoke_viz_v0200_provenance_archive_and_schemas():
manifest = release.extractfile(f"{_RELEASE_DIR}/MANIFEST")
assert manifest is not None
assert manifest.read().decode() == (
f"version=0.20.0\ncommit={_SOURCE_COMMIT}\n"
f"version=0.20.1\ncommit={_SOURCE_COMMIT}\n"
)
for filename in (
"rtichoke-viz.css",
Expand All @@ -43,6 +43,7 @@ def test_vendored_rtichoke_viz_v0200_provenance_archive_and_schemas():
assert packaged is not None
assert (_VENDOR / filename).read_bytes() == packaged.read()

assert not (_VENDOR / "rtichoke-viz-0.20.0.tar.gz").exists()
assert not (_VENDOR / "rtichoke-viz-0.19.0.tar.gz").exists()
assert not (_VENDOR / "rtichoke-viz-0.14.0.tar.gz").exists()
assert (_VENDOR / "rtichoke-viz.js").stat().st_size > 0
Expand All @@ -59,7 +60,7 @@ def test_vendored_rtichoke_viz_v0200_provenance_archive_and_schemas():
assert '"summary_metrics"' in report_schema


def test_v0200_bundle_keeps_existing_exports_and_time_dependent_surfaces():
def test_v0201_bundle_keeps_existing_exports_and_time_dependent_surfaces():
bundle = (_VENDOR / "rtichoke-viz.js").read_text(encoding="utf-8")
for export_name in (
"renderRoc",
Expand Down
Loading