Skip to content

Add canonical browser support for time ROC - #404

Merged
uriahf merged 1 commit into
mainfrom
feat/time-roc-browser-369853476287251879
Sep 1, 2026
Merged

Add canonical browser support for time ROC#404
uriahf merged 1 commit into
mainfrom
feat/time-roc-browser-369853476287251879

Conversation

@uriahf

@uriahf uriahf commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary of Changes

  1. Canonical Time ROC Builder (_roc_times_v2_spec_from_performance_data):

    • Added _roc_times_v2_spec_from_performance_data() in src/rtichoke/_viz_spec_v2.py.
    • Uses x = "false_positive_rate" and y = "sensitivity" with [0, 1] axis domains and standard identity reference line.
    • Preserves false_positive_rate, sensitivity, specificity, cutoff, and ppcr without statistical recalculation.
    • Emits operatingPoint metadata for "probability_threshold" or "ppcr".
  2. Standalone Browser Support (create_roc_curve_times):

    • Added renderer: str = "plotly" to create_roc_curve_times().
    • Supports "browser" and "rtichoke_viz" opt-in to return RtichokeBrowserChart, while preserving plotly as default.
    • Raises ValueError for unsupported renderers such as "matplotlib".
  3. Time Summary Report Insertion (create_summary_report_times):

    • Added ROC (id="roc") to the threshold discrimination group with operating_point_dimension="probability_threshold".
    • Added ROC (id="roc-2") to the PPCR discrimination group with operating_point_dimension="ppcr".
  4. Testing & Validation:

    • Added unit and browser execution tests in tests/test_time_roc_v2.py.
    • Updated tests/test_summary_report_times_browser.py to verify threshold and PPCR ROC section inclusion and operating-point metadata.
    • All 306 pytest tests pass. ruff check, ruff format, and ty typecheck passed cleanly.

PR created automatically by Jules for task 369853476287251879 started by @uriahf

Implement canonical adapter for time ROC and integrate standalone
browser rendering and summary report insertion.

Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-01 14:51 UTC

@uriahf
uriahf merged commit ad0fc1c into main Sep 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant