Add canonical browser support for time ROC - #404
Conversation
Implement canonical adapter for time ROC and integrate standalone browser rendering and summary report insertion. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Summary of Changes
Canonical Time ROC Builder (
_roc_times_v2_spec_from_performance_data):_roc_times_v2_spec_from_performance_data()insrc/rtichoke/_viz_spec_v2.py.x = "false_positive_rate"andy = "sensitivity"with[0, 1]axis domains and standard identity reference line.false_positive_rate,sensitivity,specificity,cutoff, andppcrwithout statistical recalculation.operatingPointmetadata for"probability_threshold"or"ppcr".Standalone Browser Support (
create_roc_curve_times):renderer: str = "plotly"tocreate_roc_curve_times()."browser"and"rtichoke_viz"opt-in to returnRtichokeBrowserChart, while preservingplotlyas default.ValueErrorfor unsupported renderers such as"matplotlib".Time Summary Report Insertion (
create_summary_report_times):id="roc") to the threshold discrimination group withoperating_point_dimension="probability_threshold".id="roc-2") to the PPCR discrimination group withoperating_point_dimension="ppcr".Testing & Validation:
tests/test_time_roc_v2.py.tests/test_summary_report_times_browser.pyto verify threshold and PPCR ROC section inclusion and operating-point metadata.PR created automatically by Jules for task 369853476287251879 started by @uriahf