Skip to content

Activate browser operating-point controls - #403

Merged
uriahf merged 1 commit into
mainfrom
activate-operating-point-controls-4708834464914728002
Sep 1, 2026
Merged

Activate browser operating-point controls#403
uriahf merged 1 commit into
mainfrom
activate-operating-point-controls-4708834464914728002

Conversation

@uriahf

@uriahf uriahf commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary of Changes

This PR activates the existing rtichoke_viz v0.18 operating-point sliders and selected-point markers across Python browser charts and summary reports by emitting the top-level operatingPoint metadata ({"dimension": "probability_threshold"} or {"dimension": "ppcr"}).

Audit & State:

  • Starting main SHA: a8583a46ab02c0beaae01f377b701a1fe1102f3d
  • Package version: 0.1.36
  • Vendored rtichoke_viz version: v0.18.0 (source_commit=dbabedb495ab70062ee635cd9d59eefcafe55a43, sha256=1cd3af962be8357d0fd4c2f2ecf5e5953774683de8854ead2facbac807b6bc84)

Component Activation Matrix:

  • Static ROC: operatingPoint: {dimension: "probability_threshold" | "ppcr"} (data contains cutoff + ppcr)
  • Static Precision-Recall: operatingPoint: {dimension: "probability_threshold" | "ppcr"} (data contains cutoff + ppcr)
  • Static Gains: operatingPoint: {dimension: "probability_threshold" | "ppcr"} (data contains cutoff + ppcr)
  • Static Lift: operatingPoint: {dimension: "probability_threshold" | "ppcr"} (data contains cutoff + ppcr)
  • Static Decision Curve: operatingPoint: {dimension: "probability_threshold"} (data contains threshold)
  • Static Interventions Avoided: operatingPoint: {dimension: "probability_threshold"} (data contains threshold)
  • Time-Dependent Precision-Recall: operatingPoint: {dimension: "probability_threshold" | "ppcr"} (data contains cutoff + ppcr, series contains horizon)
  • Time-Dependent Gains: operatingPoint: {dimension: "probability_threshold" | "ppcr"} (data contains cutoff + ppcr, series contains horizon)
  • Time-Dependent Lift: operatingPoint: {dimension: "probability_threshold" | "ppcr"} (data contains cutoff + ppcr, series contains horizon)
  • Time-Dependent Decision Curve: operatingPoint: {dimension: "probability_threshold"} (data contains threshold, series contains horizon)
  • Time-Dependent Interventions Avoided: operatingPoint: {dimension: "probability_threshold"} (data contains threshold, series contains horizon)
  • Calibration (Smooth & Discrete): No operating-point controls added (omitted as required).
  • Time ROC: Left unchanged (no canonical spec builder exists in Python currently).

Files Changed:

  • src/rtichoke/_viz_spec_v2.py
  • src/rtichoke/_decision_curve_viz_spec_v2.py
  • src/rtichoke/_interventions_avoided_viz_spec_v2.py
  • src/rtichoke/discrimination/precision_recall.py
  • src/rtichoke/discrimination/gains.py
  • src/rtichoke/discrimination/lift.py
  • src/rtichoke/utility/decision.py
  • src/rtichoke/summary_report/summary_report.py
  • tests/test_precision_recall_v2.py
  • tests/test_summary_report_times_browser.py
  • tests/test_operating_point_metadata.py

Testing & Verification:

  • All 300 unit and browser integration tests pass (uv run pytest).
  • Ruff linting and formatting pass cleanly (uv run ruff check, uv run ruff format).
  • Confirmed no statistical estimators or calculations were modified or added.

PR created automatically by Jules for task 4708834464914728002 started by @uriahf

- Attach top-level operatingPoint metadata to canonical v2 specs.
- Preserve cutoff and ppcr fields in curve data payloads.
- Wire standalone browser renderers and summary reports.

Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-01 13:51 UTC

@uriahf
uriahf merged commit 46c1ec6 into main Sep 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant