Build canonical v2 Lift specs in Python - #379
Conversation
Implement canonical static and time-dependent Lift v2 spec builders in Python. Preserve statistical calculations, semantic evaluation metadata, Plotly production renderer, and reference ownership for equal prevalence or event risk scenarios. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Remove unused imports from tests/test_lift_v2.py and tests/test_time_lift_v2.py to satisfy ruff linting. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
Run `ruff format .` to format tests/test_lift_v2.py and pass ruff format CI check. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
1 participant
This PR implements canonical static and time-dependent Lift v2 production adoption in Python.
Key additions:
_lift_v2_spec_from_performance_dataand_lift_times_v2_spec_from_performance_datainternal spec builders insrc/rtichoke/_viz_spec_v2.py[(0, 1/p), (p, 1/p), (1, 1)]scoped topopulation(static) orpopulation_horizon(time-dependent)value = 1scoped globally_render_lift_v2insrc/rtichoke/_renderers.pycreate_lift_curveandcreate_lift_curve_timesinsrc/rtichoke/discrimination/lift.pywithrenderer: str = "plotly"parameter, maintaining Plotly as the authoritative default and blocking browser rendering until a newer vendoredrtichoke_vizrelease containing Lift support is cuttests/test_lift_v2.pyandtests/test_time_lift_v2.pyPR created automatically by Jules for task 5323620091527145700 started by @uriahf