Add canonical time-dependent gains rendering - #378
Merged
Conversation
Contributor
|
uriahf
marked this pull request as ready for review
August 23, 2026 06:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderer=selection tocreate_gains_curve_times()while preserving Plotly as the unchanged default production pathStatistical boundary
The Perfect Model bend is the already-calculated horizon-specific target-event risk:
real_positives / nat cutoff 0.Those counts originate in the production Aalen–Johansen pipeline (
polarstate.predict_aj_estimatesand the performance-data transforms). The canonical builder copies that calculated quantity and does not recompute AJ/CIF, censoring, competing risks, or prevalence.Ownership
population_horizonownerreference_groupis used only as the compatibility join into explicit evaluation metadataContract
No schema change is required. Existing evaluation identity, series
horizon,seriesId, path geometry, andpopulation_horizonreference ownership are sufficient and language-neutral for future R adoption.Browser dependency
The immutable
rtichoke_vizv0.3.1 release is vendored in this PR. Provenance is pinned to source commit5ccde928a0bf9fa6ece2b7572687b442c57a98a9and release SHA-256121aa8eb8d0f8427ecfb2c01dab0fb05668eaedf47ddcfc0cd282a7ecf1ce448. The shipped browser bundle includes the horizon selector from uriahf/rtichoke_viz#30.Verification
uv build: passed; wheel contains v0.3.1 and excludes v0.3.0rtichoke_viztests: 71 passed; TypeScript typecheck passedty check src testscontinues to report pre-existing test diagnostics outside this diff