Skip to content

Add internal canonical gains v2 builder - #376

Merged
uriahf merged 2 commits into
mainfrom
feature/gains-v2-builder
Aug 22, 2026
Merged

Add internal canonical gains v2 builder#376
uriahf merged 2 commits into
mainfrom
feature/gains-v2-builder

Conversation

@uriahf

@uriahf uriahf commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

Adds the smallest internal-only canonical rtichoke_viz v2 builder for gains.

  • reuses the semantic evaluation metadata and deterministic evaluation/series identity pattern established by the ROC v2 builder
  • emits gains data as ppcr × sensitivity
  • keeps the random benchmark global
  • emits one population-owned perfect-model path per semantic population
  • derives prevalence from existing production real_positives / n quantities rather than recalculating outcomes in the visualization layer
  • maps compatibility/reference groups through semantic metadata before assigning population ownership
  • keeps equal-prevalence populations as distinct reference owners
  • preserves model-unknown population semantics
  • does not switch production rendering to v2
  • does not change public APIs or statistical calculations

Tests

Adds focused coverage for:

  • prevalence-dependent perfect path geometry
  • two models sharing one population and one perfect reference
  • equal-prevalence populations remaining distinct owners
  • existing ROC-v2 behavior remains covered

CI should verify formatting, typing, and the full Python test suite.

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-22 13:05 UTC

@uriahf
uriahf merged commit 901f4bc into main Aug 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant