Preserve model vs population semantics in performance tables - #371
Merged
Conversation
Contributor
|
uriahf
marked this pull request as ready for review
August 21, 2026 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Align Python performance-table presentation with the merged evaluation semantic contract without changing prepared-performance-data schemas or public APIs.
Problem
Both Python table renderers currently rename the generic compatibility field
reference_grouptoModel. For keyed population/evaluation inputs, those groups are populations, so the rendered table can labelPopulation Aunder aModelheading. R preserves the known semantic role and rendersModelorPopulationaccordingly.Change
High-level
create_performance_table()andcreate_performance_table_times()now derive the known evaluation role from the existing internal evaluation metadata and attach it only as transient render-path metadata.Model;Population;render_performance_table(prepared_data)retains the existing default behavior because the original input identity is no longer available there.Both Great Tables and Reactable use the transient role only for rendering/group-label semantics and coloring.
Compatibility
prepare_performance_data()orprepare_performance_data_times()return schemas;rtichoke_vizchanges.Tests
Adds regression coverage that shared-outcome create paths propagate model role, keyed population paths propagate population role, and
prepare_performance_data_times()itself remains free of the transient render metadata.