Add internal evaluation semantic metadata - #369
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add non-breaking internal semantic metadata for the parity work without changing current public or rendered behavior.
What this adds
Adds an internal
_EvaluationMetadatarepresentation and_build_evaluation_metadata()helper that records the semantic information that can be known from current input shapes while preservingreference_groupas the compatibility grouping key.Nonebecause the current API does not encode it separately;Compatibility
This helper is internal and is not yet wired into rendering, reference ownership, performance tables, or public return values. Existing trace names/counts, legends, colors, statistical calculations, dataframe schemas, and APIs are unchanged.
This is deliberately preparatory groundwork for the later behavioral reference-ownership change in #368.
Tests
Adds focused tests for shared-model, keyed-population, and paired-label semantics.
Scope
No public API changes, no statistical changes, no plotting changes, no
rtichoke_vizchanges.