Characterize time-dependent evaluation semantics - #366
Merged
Conversation
Contributor
|
uriahf
marked this pull request as ready for review
August 21, 2026 11:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Implement Stage 1B of the cross-language semantic audit as Python characterization tests only.
Coverage
Adds focused tests for time-dependent semantics across multiple horizons:
reference_group × fixed_time_horizonCharacterized current behavior
The time-dependent input/output contract does not carry separate
modelandpopulationdimensions. Multiple keyed evaluations and explicit model-population pairs remain genericreference_groups.Reference-line scope is currently inferred from whether horizon-specific event risks differ across
reference_groups. As a result:This PR records those semantics rather than changing them.
Scope
Test-only. No statistical calculations, public APIs, production behavior, plotting code, package metadata, documentation, or
rtichoke_vizare changed.Verification
The final diff contains one added test file only. Python package CI passes on 3.12, 3.13, and 3.14, including Ruff lint/format, type checking, package build, and the full 169-test suite.