Skip to content

Probe ty readiness in CI - #347

Merged
uriahf merged 1 commit into
mainfrom
modernize/ty-ci-probe
Aug 20, 2026
Merged

Probe ty readiness in CI#347
uriahf merged 1 commit into
mainfrom
modernize/ty-ci-probe

Conversation

@uriahf

@uriahf uriahf commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • run uv run ty check src/rtichoke in package CI
  • keep the type-check step non-blocking while we establish the baseline

Baseline

ty reports 11 diagnostics on the current package source:

  • 2 intentional calibration export/shadowing assignments in calibration/__init__.py
  • 1 internal times annotation mismatch in performance_table.py
  • 4 Polars scalar-narrowing issues around max() values used as floats
  • 1 Reactable callable/stub mismatch for details=confusion_matrix
  • 3 NumPy-array vs list annotation mismatches in processing/combinations.py

The package CI otherwise passes: Ruff lint, Ruff format, build, and all 137 tests.

Scope

Developer tooling only. No type fixes, runtime dependencies, API changes, statistical changes, or functional refactoring.

Recommendation

Keep this probe non-blocking for now. The 11-error baseline is small enough to address incrementally in a follow-up PR; once it reaches zero, make ty blocking in CI.

@uriahf
uriahf marked this pull request as ready for review August 20, 2026 18:58
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-20 19:00 UTC

@uriahf
uriahf merged commit 57fd460 into main Aug 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant