Stabilize time-dependent performance-data column order - #339
Merged
Conversation
Contributor
|
uriahf
changed the title
uriahf
marked this pull request as ready for review
August 20, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare_performance_data_times()had the same pivot encounter-order instability as the binary pathexcludedoutcome explicitlyEvidence
The initial test-only PR failed only the schema-order assertion while the PPCR value-equivalence test passed. The difference was confined to the order of
excluded/ TP / TN / FP / FN columns.Audit classification
Harmless API inconsistency: Polars pivot encounter order could reorder outcome columns depending on stratification.
No statistical calculations, censoring/competing heuristics, cutoff semantics, defaults, or dependencies change.