Skip to content

Stabilize binary performance-data column order - #338

Merged
uriahf merged 2 commits into
mainfrom
fix/performance-schema-order
Aug 20, 2026
Merged

Stabilize binary performance-data column order#338
uriahf merged 2 commits into
mainfrom
fix/performance-schema-order

Conversation

@uriahf

@uriahf uriahf commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • make prepare_performance_data() return one deterministic column order regardless of requested stratification
  • preserve all metric values and row ordering
  • add regression coverage for probability-threshold-only, PPCR-only, and combined stratification
  • verify combined PPCR values still match PPCR-only output

Audit classification

Harmless API inconsistency: Polars pivot encounter order could reorder TP/TN/FP/FN columns depending on stratification, even when the returned data were otherwise identical.

No statistical calculations, cutoff semantics, defaults, or dependencies change.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-20 11:17 UTC

@uriahf
uriahf marked this pull request as ready for review August 20, 2026 11:17
@uriahf
uriahf merged commit c448c61 into main Aug 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant