Match R cutoff equality semantics - #337
Merged
Merged
Conversation
Contributor
|
uriahf
marked this pull request as ready for review
August 20, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prob == cutoffis predicted negative because R usesprob > cutoffprob >= cutoffconvention required fordcurvessurvival decision-curve parityImplementation
Only binary data preparation is adjusted. Probabilities exactly equal to a nonzero public cutoff are moved one representable float downward for internal bin assignment; public probabilities/cutoffs and all non-boundary values are unchanged.
Evidence
The initial test-only commit failed both binary and time equality assertions. Existing
dcurvesparity coverage then showed that changing time semantics would be incorrect, so the final fix is binary-only.Audit classification
rtichoke>=behavior: intentional methodological difference fordcurvesparityNo statistical formulas, censoring heuristics, schemas, or dependencies are changed.