Skip to content

Honor custom colors in binary curves - #335

Merged
uriahf merged 8 commits into
mainfrom
fix/binary-color-values
Aug 20, 2026
Merged

Honor custom colors in binary curves#335
uriahf merged 8 commits into
mainfrom
fix/binary-color-values

Conversation

@uriahf

@uriahf uriahf commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • make binary ROC, precision-recall, lift, gains, and decision create_* functions honor color_values
  • preserve R behavior where a single model remains black
  • recolor group-specific reference traces consistently with their model/population
  • validate that a custom palette has enough colors
  • add end-to-end regression tests across the binary curve family

Scope

No statistical calculations, cutoff semantics, schemas, or runtime dependencies are changed.

Audit classification

Correctness/API bug: binary public curve creators accepted color_values but silently rendered the built-in palette instead.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-20 11:03 UTC

@uriahf
uriahf marked this pull request as ready for review August 20, 2026 11:02
@uriahf
uriahf merged commit c444f66 into main Aug 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant