Skip to content

Order time-dependent performance data for cross-group comparison - #331

Merged
uriahf merged 12 commits into
mainfrom
fix/time-performance-order
Aug 20, 2026
Merged

Order time-dependent performance data for cross-group comparison#331
uriahf merged 12 commits into
mainfrom
fix/time-performance-order

Conversation

@uriahf

@uriahf uriahf commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • order prepare_performance_data_times() by horizon, heuristic set, stratification, and cutoff first
  • keep different reference_group values adjacent within each comparison point
  • preserve caller-supplied reference-group, horizon, and heuristic-set order through explicit ordinal columns
  • use one native Polars sort; no nested filtering/concatenation loops
  • update regression coverage to assert that each comparison block contains reference groups in caller-supplied order

Why

The returned performance data is primarily used to compare populations/models at the same horizon and cutoff. Keeping reference groups adjacent within the same comparison point makes that comparison much clearer than grouping the entire table by reference group first.

Scope

No metric calculations, AJ adjustments, schemas, plotting behavior, or heuristic definitions are changed.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-20 09:24 UTC

@uriahf uriahf changed the title Sort time-dependent performance data deterministically Match R-style ordering in time-dependent performance data Aug 20, 2026
@uriahf uriahf changed the title Match R-style ordering in time-dependent performance data Order time-dependent performance data for cross-group comparison Aug 20, 2026
@uriahf
uriahf marked this pull request as ready for review August 20, 2026 09:23
@uriahf
uriahf merged commit eea1226 into main Aug 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant