Skip to content

test: lock dcurves parity for issue #127 - #327

Merged
uriahf merged 4 commits into
mainfrom
test/dcurves-issue-127-regression
Aug 20, 2026
Merged

test: lock dcurves parity for issue #127#327
uriahf merged 4 commits into
mainfrom
test/dcurves-issue-127-regression

Conversation

@uriahf

@uriahf uriahf commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Adds regression coverage for issue #127 without changing implementation.

  • compares rtichoke time-dependent DCA with dcurves on the bundled df_surv example at 1.5 years
  • checks the reported ~0.22 whole-cohort event prevalence
  • compares threshold-specific TP rate, FP rate, and net benefit at representative cutoffs
  • adds an exact-threshold boundary case to preserve the prediction >= threshold convention

If these tests pass on current main, #127 can be treated as already resolved by the later pooled-by-cutoff changes.

@uriahf
uriahf marked this pull request as ready for review August 20, 2026 06:55
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-20 07:07 UTC

@uriahf
uriahf merged commit 9dbd166 into main Aug 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant