Remove legacy lifelines Cox smoothing - #318
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the secondary-Cox calibration path now that
smoothstateis the active implementation.This PR removes the old in-module lifelines/RCS implementation, routes secondary-Cox smoothing directly through
src/rtichoke/calibration/_secondary_cox.py, and removes the import-time secondary-Cox monkey patch fromcalibration/__init__.py.lifelinesintentionally remains a dev-only dependency becausetests/test_calibration_times.pystill uses its Kaplan-Meier and Aalen-Johansen estimators as independent validation references. Runtime users do not install it.The cleanup preserves the existing Aalen-Johansen fallback behavior and keeps the public calibration API unchanged.