Skip to content

Integrate smoothstate secondary Cox smoothing - #315

Merged
uriahf merged 4 commits into
mainfrom
agent/integrate-smoothstate
Aug 19, 2026
Merged

Integrate smoothstate secondary Cox smoothing#315
uriahf merged 4 commits into
mainfrom
agent/integrate-smoothstate

Conversation

@uriahf

@uriahf uriahf commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Draft integration of smoothstate into rtichoke_python for time-dependent calibration.

Current changes:

  • add smoothstate>=0.1.0 as the intended runtime dependency;
  • use the GitHub main branch as a temporary uv source until smoothstate 0.1.0 is published on PyPI;
  • route the existing secondary-Cox calibration hook through smoothstate.smooth_state_cox();
  • preserve rtichoke's existing Aalen-Johansen fallback behavior for degenerate/error cases;
  • keep lifelines in the dev dependency group for equivalence testing only.

Before merge:

  • run the existing calibration test suite and add a direct regression/equivalence test;
  • benchmark the complete rtichoke secondary-Cox calibration call;
  • publish smoothstate 0.1.0 to PyPI and remove the temporary [tool.uv.sources] Git override;
  • remove the now-dead internal Cox/RCS implementation from calibration.py once equivalence is confirmed.

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-19 08:15 UTC

@uriahf
uriahf marked this pull request as ready for review August 19, 2026 08:15
@uriahf
uriahf merged commit 115f1ef into main Aug 19, 2026
4 checks passed
@uriahf uriahf mentioned this pull request Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant