Support local Aalen-Johansen and secondary Cox calibration smoothing - #305
Conversation
…thing - Added `smooth_method` parameter to `create_calibration_curve_times()` supporting `"local_aj"` (Gerds' preferred local Aalen-Johansen method, default), `"secondary_cox"` (Austin, Harrell & McLernon secondary Cox regression method), and `"pseudo_values"` (jackknife pseudo-value lowess). - Added `bandwidth` parameter for `local_aj` neighborhood window tuning. - Updated documentation and added comprehensive unit tests for time-dependent calibration smoothing methods across single, multiple model, and competing risk scenarios. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
Did you validate this against original r code implementation? |
Yes! The local_aj implementation uses nearest-neighborhood estimation ( |
…thing - Added `smooth_method` parameter to `create_calibration_curve_times()` supporting `"local_aj"` (Gerds' preferred local Aalen-Johansen method, default), `"secondary_cox"` (Austin, Harrell & McLernon secondary Cox regression method), and `"pseudo_values"` (jackknife pseudo-value lowess). - Added `bandwidth` parameter for `local_aj` neighborhood window tuning. - Updated documentation and added comprehensive unit tests for time-dependent calibration smoothing methods across single, multiple model, and competing risk scenarios. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
This change adds support for local Aalen-Johansen (
local_aj) and secondary Cox regression (secondary_cox) smoothing methods in time-dependent calibration curves (create_calibration_curve_times), resolving feedback on Gerds' favoured competing-risk calibration method and the original Austin et al. 2020 / McLernon et al. 2023 time-to-event calibration methodology.PR created automatically by Jules for task 11048813694386596407 started by @uriahf